New issue
Advanced search Search tips

Issue 825306 link

Starred by 1 user
Status: Fixed
Owner:
jsaul@google.com
Closed: Mar 2018
Cc:
dennishu@google.com
dlkumar@google.com
chrome-autofill@google.com
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for reverting AutofillCreditCardBankNameDisplay flag cleanup

Project Member Reported by jsaul@google.com, Mar 23 2018 
This is a merge request for:

Revert "Clean up kAutofillCreditCardBankNameDisplay flag"
https://chromium-review.googlesource.com/c/chromium/src/+/974342

While metrics looked okay as we rolled this feature out, we're not yet convinced it's having a positive impact, so we want to perform a 1% Stable holdback on the experiment to gather more data.

However, the flag was cleaned up in M66, meaning the holdback will only apply to M65 and M67 unless the cleanup revert is approved.

Comment 1 by jsaul@google.com, Mar 27 2018

Labels: -Pri-3 Merge-Request-66 M-66 Pri-2
Tested successfully in Canary 67.0.3381.0; this change just re-adds a flag that was cleaned up.  Requesting merge into M66.

Comment 2 by jsaul@google.com, Mar 27 2018

Cc: chrome-autofill@google.com
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: Less than 17 days to go before AppStore submit on M66
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cmasso@google.com, Mar 27 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66

Comment 5 by jsaul@google.com, Mar 27 2018

Labels: -Merge-Approved-66 merge-merged-3359
Status: Fixed (was: Assigned)
Merged to 3359 using git drover (some experiment flag files conflicted).
►

Sign in to add a comment