New issue
Advanced search Search tips

Issue 825305 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

browser_test TabRestoreTest.RestoreTabWithSpecialURL[OnBack] flaky

Project Member Reported by wolenetz@chromium.org, Mar 23 2018

Issue description

Summary: browser_test TabRestoreTest.RestoreTabWithSpecialURL[OnBack] flaky (was: browser_test TabRestoreTest.RestoreTabWithSpecialURLOnBack flaky timeout on Win7 Tests (dbg)(1) bot)
More flakiness in that suite included in this issue. I'll mark multiple others, too:

TabRestoreTest.RestoreTabWithSpecialURL is similarly flaky on that dbg win bot.

TabRestoreTest.RestoreTabWithSpecialURL is also flaky on Linux Chromium OS ASan LSan Tests (1)
-> the *OnBack test was previously conditionally disabled in bug 667932.

See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TabRestoreTest
@#1 the TabRestoreTest.RestoreTabWithSpecialURL flakiness on Linux Chromium OS ASan LSan Tests (1) is FAIL/PASS, not timeout.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e384121dcb312b7007e90438cffe717f5ac75c4

commit 6e384121dcb312b7007e90438cffe717f5ac75c4
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Fri Mar 23 19:52:19 2018

browser_test TabRestoreTest.RestoreTabWithSpecialURL[OnBack] flaky

Adds conditional disabling of these two tests.

BUG=825305, 823003 
TBR=sky@chromium.org,creis@chromium.org
NO-TRY=True

Change-Id: I9c24882c82db878883a9cd8df9abe3f95723634c
Reviewed-on: https://chromium-review.googlesource.com/978666
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545560}
[modify] https://crrev.com/6e384121dcb312b7007e90438cffe717f5ac75c4/chrome/browser/sessions/tab_restore_browsertest.cc

Comment 4 by gab@chromium.org, Jan 18 (4 days ago)

Also flaking on win10_chromium_x64_rel_ng, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng/179626

Looks like another process (renderer or network service?) crashes with EXCEPTION_STACK_OVERFLOW and thus makes the test resume without rendered content..


[ RUN      ] TabRestoreTest.RestoreTabWithSpecialURL
[5492:8172:0118/071942.055:WARNING:chrome_browser_main_win.cc(659)] Command line too long for RegisterApplicationRestart:  --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=TabRestoreTest.RestoreTabWithSpecialURL --single_process --test-launcher-bot-mode --test-launcher-output="C:\b\s\w\itcdjyu8\scoped_dir8100_28664\results8100_9070\test_results.xml" --test-launcher-summary-output="C:\b\s\w\io9qwsuj\output.json" --user-data-dir="C:\b\s\w\itcdjyu8\scoped_dir8100_28664\d8100_6466" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --browser-test --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=TestFeatureForBrowserTest2,WebRTC-H264WithOpenH264FFmpeg --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release_x64\gen" --restore-last-session about:blank
[5492:8172:0118/071942.200:WARNING:personal_data_manager.cc(487)] 000001DA7B329800 refresh is done, notifying PersonalDataChanged
[3584:528:0118/071942.962:ERROR:direct_composition_surface_win.cc(1677)] EGL_ANGLE_flexible_surface_compatibility not supported
[5492:7704:0118/071943.740:WARNING:discovery_network_list_win.cc(196)] Failed to open Wlan client handle: 1062
[5492:8172:0118/071943.852:WARNING:gaia_auth_fetcher.cc(881)] Could not reach Google Accounts servers: errno -11
[5492:8172:0118/071944.846:WARNING:gaia_auth_fetcher.cc(881)] Could not reach Google Accounts servers: errno -11
[5492:8172:0118/071947.706:WARNING:gaia_auth_fetcher.cc(881)] Could not reach Google Accounts servers: errno -11
[5492:6112:0118/071947.738:WARNING:leveldb_database.cc(111)] Unable to open C:\b\s\w\itcdjyu8\scoped_dir8100_28664\d8100_6466\Default\shared_proto_db: Invalid argument: C:\b\s\w\itcdjyu8\scoped_dir8100_28664\d8100_6466\Default\shared_proto_db: does not exist (create_if_missing is false)
[5492:5752:0118/071947.866:ERROR:process_win.cc(167)] Unable to terminate process: Access is denied. (0x5)
[5492:5752:0118/071947.867:ERROR:process_win.cc(167)] Unable to terminate process: Access is denied. (0x5)
Received fatal exception EXCEPTION_STACK_OVERFLOW
../../chrome/browser/sessions/tab_restore_browsertest.cc(752): error: Expected: (ui_test_utils::FindInPage(tab, base::ASCIIToUTF16("webkit"), true, false, 0, 0)) > (0), actual: 0 vs 0
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF61F761D57+87]
	testing::internal::AssertHelper::operator= [0x00007FF61F7618DE+78]
	TabRestoreTest_RestoreTabWithSpecialURL_Test::RunTestOnMainThread [0x00007FF61EBC9699+569]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF622727263+483]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF6238CDD4C+4908]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF6238CC95B+155]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF62053EA86+54]
	content::StartupTaskRunner::RunAllTasksNow [0x00007FF620973305+37]
	content::BrowserMainLoop::CreateStartupTasks [0x00007FF62053D876+774]
	content::BrowserMainRunnerImpl::Initialize [0x00007FF620540F48+104]
	content::BrowserMain [0x00007FF62053B931+161]
	content::RunBrowserProcessMain [0x00007FF62222592F+111]
	content::ContentMainRunnerImpl::RunServiceManager [0x00007FF6222264CF+783]
	content::ContentMainRunnerImpl::Run [0x00007FF62222618E+382]
	service_manager::Main [0x00007FF62306D517+2151]
	content::ContentMain [0x00007FF62222584E+62]
	content::BrowserTestBase::SetUp [0x00007FF622726F4A+2218]
	InProcessBrowserTest::SetUp [0x00007FF622515285+501]

[5492:88:0118/071950.053:ERROR:browser_process_sub_thread.cc(209)] Waited 15 ms for network service
[5492:5752:0118/071950.055:ERROR:process_win.cc(167)] Unable to terminate process: Access is denied. (0x5)
[5492:5752:0118/071950.055:ERROR:activity_tracker.cc(1491)] Recording exit of unknown process #304
[5492:5752:0118/071950.056:ERROR:process_win.cc(167)] Unable to terminate process: Access is denied. (0x5)
[5492:88:0118/071950.056:WARNING:discardable_shared_memory_manager.cc(410)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[5492:8172:0118/071950.057:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[5492:8172:0118/071950.057:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] TabRestoreTest.RestoreTabWithSpecialURL, where TypeParam =  and GetParam() =  (8128 ms)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f183fb456d036882ab326c771cc48b5a6174d12b

commit f183fb456d036882ab326c771cc48b5a6174d12b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jan 18 17:38:04 2019

Disable TabRestoreTest.RestoreTabWithSpecialURL on windows.

Tbr: chrisha@chromium.org,sky@chromium.org,gab@chromium.org
Bug: 825305
Change-Id: I662b4fa1e6ae45ef9c8864db0f3ddd15ea544591
Reviewed-on: https://chromium-review.googlesource.com/c/1421679
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624184}
[modify] https://crrev.com/f183fb456d036882ab326c771cc48b5a6174d12b/chrome/browser/sessions/tab_restore_browsertest.cc

Comment 7 by chrisha@chromium.org, Yesterday (42 hours ago)

Owner: chrishall@chromium.org
Assigning to self to investigate and hopefully re-enable.

Comment 8 by chrishall@chromium.org, Yesterday (36 hours ago)

Owner: chrisha@chromium.org
maybe you meant yourself =3

Comment 9 by chrisha@chromium.org, Today (21 hours ago)

Indeed I did. Autocomplete always brings up your LDAP first :)

Sign in to add a comment