New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825289 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app: Handle long file names properly in progress center

Project Member Reported by sdantul...@chromium.org, Mar 23 2018

Issue description

Google Chrome	66.0.3359.48 (Official Build) dev (64-bit)
Revision	0
Platform	10452.22.0 (Official Build) dev-channel caroline

What steps will reproduce the problem?
(1) Open File Manager Drive
(2) Right click on a file with long file name and choose 'Available Offline' option
(3) See that a file sync message appears in the status area of the app
(4) Look for close icon to cancel the file sync

What is the expected result?
Close icon should be visible

What happens instead?
Close icon is not visible when file name is long
 
Cc: sashab@chromium.org
Labels: -Pri-2 -M-66 Pri-3
Status: Available (was: Untriaged)
Labels: -Pri-3 M-68 Pri-2
Summary: Files app: Handle long file names properly in progress center (was: Files app: Close icon is not visible in status area when file name is long)
We are likely to see an increase in long file names with the introduction of Crostini. We should determine if/how to handle long file names better in the progress center.
image.png
10.6 KB View Download

Comment 4 by sashab@google.com, May 24 2018

Labels: -M-68 M-69
Labels: -M-69 M-71
 Issue 883433  has been merged into this issue.
Labels: -M-71 M-72 CrOSFilesCategory-UI
Labels: Files-Fixit-2018
Owner: joelhockey@chromium.org
Status: Started (was: Available)
Fixed display of name to fit within the available area and still show open/close buttons.
Screenshot 2018-11-19 at 15.47.48.png
68.9 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf38321e881a93d11036c802360cb91417a4ff9c

commit cf38321e881a93d11036c802360cb91417a4ff9c
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Nov 19 06:31:57 2018

FilesApp fix display of long filename in progress center

Setting |overflow: none| in .progress-frame fixes it to display
long filenames and the open/close controls within the visible
space and intended.

Bug:  825289 
Change-Id: Id5027bf73961063f8568083d744264e9021aeb1a
Reviewed-on: https://chromium-review.googlesource.com/c/1341728
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609188}
[modify] https://crrev.com/cf38321e881a93d11036c802360cb91417a4ff9c/ui/file_manager/file_manager/foreground/css/file_manager.css

Status: Fixed (was: Started)

Sign in to add a comment