Issue 825274 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Mar 2018
Cc:	l...@chromium.org
Components:	Platform>DevTools>Memory
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug-Regression

Find in heap snapshot is unusable as typing there causes focus to go away

Project Member Reported by alph@chromium.org, Mar 23 2018

Issue description

To repro:

1. Open memory panel in DT
2. take a heap snapshot
3. press ctrl+F (cmd+F)
4. type: window
5. see the focus moves to filter toolbar control while typing

Regression bisect points to:
https://chromium.googlesource.com/chromium/src/+/a57d5aa65194cc780ab7039d97aa33d11c6d6585

The focus is lost because of the filter field gets cleared on search. It makes a call to selection.addRange which grabs the focus.

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js?type=cs&q=selection.addrange+f:textprompt&l=637

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec

commit 2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Mar 27 17:01:21 2018

DevTools: Fix search in heap snapshot losing focus.

- Make UI.ToolbarInput control to not grab focus on text change.
- Make sure revealTreeNode always resolves.

BUG= 825274 

Change-Id: Ibb4439ecc131cc74d51546c0d2247c4579735f9f
Reviewed-on: https://chromium-review.googlesource.com/978858
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546139}
[modify] https://crrev.com/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
[modify] https://crrev.com/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
[modify] https://crrev.com/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[modify] https://crrev.com/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js
[modify] https://crrev.com/2b0f4d4a8b1ef817cd3cbc94e38e3e4bfcd6c7ec/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Comment 2 by alph@chromium.org, Mar 27 2018

Status: Fixed (was: Available)

►

Issue 825274 link

Issue metadata

Find in heap snapshot is unusable as typing there causes focus to go away

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

Comment 1 Deleted

Comment 2 by alph@chromium.org, Mar 27 2018

Comment 2 Deleted

Sign in to add a comment