New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 825272 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Apr 2018
Cc:
qyears...@chromium.org
█ emso@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Tricium plugin still keeps sending requests when all analyzers are done

Project Member Reported by qyears...@chromium.org, Mar 23 2018 
This was supposed to be done in https://crrev.com/c/909994, but isn't actually done yet.

I just realized that this is because we clear the update timer when updating the state, but then immediately set it again in the then() clause of client.getProgress.

Related: I also suspect that some other aspects of the behavior may not be quite right -- I'm not sure but I think the update timer will not be set again after increasing the timeout interval if there's an error from Tricium. The test should be improved.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/459a55f77f0b9e59d6f2fc96cadbd4d4ebbf855b

commit 459a55f77f0b9e59d6f2fc96cadbd4d4ebbf855b
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Mar 28 16:19:02 2018

Fix update timeout behavior in tricium-view

Specifically:

1. After fetching new results, if all results are done,
   clear the update timeout and don't set it again.
   Previously it was being cleared in _update and then
   set again in the then clause after client.getProgress.
2. When clearing the timer, also set it to null so that we can
   check whether there's a timer set. This makes it
   consistent with the buildbucket plugin.

Bug:  825272 
Change-Id: Ic7ea376fddc2e06a7ffebc5383c038e0f73ddf13
Reviewed-on: https://chromium-review.googlesource.com/978507
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/459a55f77f0b9e59d6f2fc96cadbd4d4ebbf855b/test/tricium-view_test.html
[modify] https://crrev.com/459a55f77f0b9e59d6f2fc96cadbd4d4ebbf855b/src/main/resources/static/tricium-view.js
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/be01d2edc97b5e5ece4ff7009a46eb485170ffd9

commit be01d2edc97b5e5ece4ff7009a46eb485170ffd9
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Mar 28 17:53:05 2018

Buildbucket plugin: clarify timeout on error unit test

This CL changes that and modifies the test, and changes
the console.error to a console.warn so that the test
behaves as expected. This was necessary because in the
unit test environment, console.error throws an exception.

Bug:  825272 
Change-Id: I9bf1bada1c0de4ad850faba654d10af50a814d8d
Reviewed-on: https://chromium-review.googlesource.com/978606
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/be01d2edc97b5e5ece4ff7009a46eb485170ffd9/test/cr-buildbucket-view_test.html
[modify] https://crrev.com/be01d2edc97b5e5ece4ff7009a46eb485170ffd9/src/main/resources/static/cr-buildbucket-view.js

Comment 3 by qyears...@chromium.org, Apr 13 2018

Status: Fixed (was: Started)
Verified.
►

Sign in to add a comment