New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825270 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: ----



Sign in to add a comment

Require user gesture for PaymentRequest.show

Project Member Reported by gogerald@chromium.org, Mar 23 2018

Issue description

^^^

 
Summary: Require user gesture for PaymentRequest.show (was: Request user gesture for PaymentRequest.show)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f047de699e30cc02af610a565326e7046245187

commit 4f047de699e30cc02af610a565326e7046245187
Author: gogerald <gogerald@google.com>
Date: Tue Mar 27 00:48:07 2018

[Payments] Add a use counter to number of PaymentRequest.show without gesture

Bug: 825270
Change-Id: I978f26cbfbefa48c0c4b1dffe64d49d750749db6
Reviewed-on: https://chromium-review.googlesource.com/977950
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545911}
[modify] https://crrev.com/4f047de699e30cc02af610a565326e7046245187/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
[modify] https://crrev.com/4f047de699e30cc02af610a565326e7046245187/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/4f047de699e30cc02af610a565326e7046245187/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/4f047de699e30cc02af610a565326e7046245187/tools/metrics/histograms/enums.xml

Cc: waltercacau@chromium.org
<0.006% of users would be affected by this change.
Should be OK to start requiring user gesture after the show() promise is implemented.

Sign in to add a comment