Overflow Menu - Closing Incognito tabs should return user to NTP if no tabs are open |
|||||||||||||
Issue descriptionChrome Version: 67.0.3379.0 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? 1) Close all tabs. 2) Open an Incognito tab while outside VR. 3) Enter VR Browsing 4) Click “Close incognito tabs” button on the Overflow menu. What is the expected result? The user is returned to normal mode on a New Tab Page (NTP). What happens instead? The user is returned to normal mode on the about:blank page.
,
Mar 24 2018
Is this actually MVP? How often will a user not have a regular tab open when closing all incognito tabs? Although this is an issue we should address, I'm not sure this is MVP. Eric, could you assess in the next MVP triage pass?
,
Mar 27 2018
,
Mar 27 2018
I don't think this is MVP, could be MVP-NEXT. +skonig@ to assess product risk, but agreed it's not MVP.
,
Mar 27 2018
Agreed.
,
Apr 16 2018
,
Apr 16 2018
,
May 30 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5257d42b5bcbd2bbd50c0163a5c70a40f0fbdce commit b5257d42b5bcbd2bbd50c0163a5c70a40f0fbdce Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu May 31 15:12:07 2018 VR: Open NTP when all tabs are closed. Also fixes an issue where because of how the Tab Switcher is added to the view hierarchy, it wasn't able to receive input. Note that you can't actually get to the 2D Tab Switcher in VR anymore, the fix is general for any other UI that happens to do something similar. Bug: 825264 Change-Id: Id35191ce1ae371f75ae99397b9572adb5c3d158c Reviewed-on: https://chromium-review.googlesource.com/1079950 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#563234} [modify] https://crrev.com/b5257d42b5bcbd2bbd50c0163a5c70a40f0fbdce/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Jun 7 2018
Looks good on Canary.
,
Jun 7 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd0e747a7decc348fee1037218cfa21ad61a17e5 commit bd0e747a7decc348fee1037218cfa21ad61a17e5 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Jun 07 19:14:40 2018 VR: Open NTP when all tabs are closed. Also fixes an issue where because of how the Tab Switcher is added to the view hierarchy, it wasn't able to receive input. Note that you can't actually get to the 2D Tab Switcher in VR anymore, the fix is general for any other UI that happens to do something similar. TBR=mthiesse@chromium.org (cherry picked from commit b5257d42b5bcbd2bbd50c0163a5c70a40f0fbdce) Bug: 825264 Change-Id: Id35191ce1ae371f75ae99397b9572adb5c3d158c Reviewed-on: https://chromium-review.googlesource.com/1079950 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563234} Reviewed-on: https://chromium-review.googlesource.com/1091307 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#242} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/bd0e747a7decc348fee1037218cfa21ad61a17e5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Jun 7 2018
,
Jun 26 2018
Verified in Chrome Beta 68.0.3440.39
,
Jun 26 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ericde@google.com
, Mar 23 2018