New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825260 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Files app crashes if opened in tablet mode

Project Member Reported by x...@chromium.org, Mar 23 2018

Issue description

Chrome Version: 67.0.3379.0
OS: Chrome

What steps will reproduce the problem?
(1) Enter tablet mode
(2) Open Files app

What is the expected result?
Files app can be opened normally

What happens instead?
Chrome crashes

Not sure if it also happens in earlier version of Chrome.
 

Comment 1 by x...@chromium.org, Mar 23 2018

Callstack:
#0 0x7fde495ac24c base::debug::StackTrace::StackTrace()
#1 0x7fde495abd41 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fde497350c0 <unknown>
#3 0x7fde44ee2e40 <unknown>
#4 0x7fde438157f2 ash::HeaderView::OnImmersiveRevealStarted()
#5 0x7fde43434d70 ash::ImmersiveFullscreenController::SetEnabled()
#6 0x556cd986d3f8 ChromeNativeAppWindowViewsAuraAsh::CreateNonClientFrameView()
#7 0x7fde43f2ea7d views::Widget::CreateNonClientFrameView()
#8 0x7fde43f2ce83 views::Widget::Init()
#9 0x556cd98a19aa ChromeNativeAppWindowViews::InitializeDefaultWindow()
#10 0x556cd98a29b0 ChromeNativeAppWindowViews::InitializeWindow()
#11 0x556cd986c322 ChromeNativeAppWindowViewsAuraAsh::InitializeWindow()
#12 0x556cd9a66eeb native_app_window::NativeAppWindowViews::Init()
#13 0x556cd97a5ba3 ChromeAppWindowClient::CreateNativeAppWindowImpl()
#14 0x556cd7a39733 extensions::AppWindow::Init()
#15 0x556cd7b19fba extensions::AppWindowCreateFunction::Run()
#16 0x556cd7a5cdb2 ExtensionFunction::RunWithValidation()
#17 0x556cd7a5f4bb extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal()
#18 0x556cd7a5f05f extensions::ExtensionFunctionDispatcher::Dispatch()
#19 0x556cd7a838ea extensions::ExtensionWebContentsObserver::OnRequest()

Comment 2 by x...@chromium.org, Mar 23 2018

Labels: RegressedIn-67
Owner: osh...@chromium.org
Status: Assigned (was: Untriaged)
Locally confirmed that https://chromium-review.googlesource.com/c/chromium/src/+/972677 caused this regression. 

Oshima, can you take a look?

Comment 3 by osh...@chromium.org, Mar 23 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/439fd0c576787f0f0e8cf4546a2c6fca05f9e592

commit 439fd0c576787f0f0e8cf4546a2c6fca05f9e592
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat Mar 24 01:39:43 2018

Fix crash when the immesriv mode is enabled during initialization

This is a temp fix. It looks like it's trying to reveal first when
created, but it doesn't work that way. This could be either regression,
or wrong, and I'll look into separately.

BUG= 825260 

Change-Id: Idc605ef9f42b48b847c3bc562ebd1d9a3a0c33c6
Reviewed-on: https://chromium-review.googlesource.com/978891
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545657}
[modify] https://crrev.com/439fd0c576787f0f0e8cf4546a2c6fca05f9e592/ash/frame/header_view.cc

Status: Fixed (was: Started)

Comment 6 by osh...@chromium.org, Apr 27 2018

Issue 837000 has been merged into this issue.

Comment 7 by osh...@chromium.org, Apr 27 2018

Cc: josa...@chromium.org
Labels: Merge-Request-66
Status: Started (was: Fixed)
The CL that caused the problem was merged (crrev.com/c/1007978) so we need to merge the fix as well.
Cc: conradlo@chromium.org
Components: Platform>Apps>Camera
this affects the camera app too
Owner: warx@chromium.org
warx@, could you please merge once approved?
It seems like the report/regression is M67, 
can you confirm merge-request (c#7) is for M66 ?

Comment 12 Deleted

Comment 13 by jean@chromium.org, Apr 30 2018

fwiw, i didn't see this issue when i was on M65 (Product Version: 65.0.3325.199 beta ,CHROMEOS_RELEASE_VERSION: 10323.65.0 ), but now i'm seeing this problem consistently on M66 ( 66.0.3359.137 beta, CHROMEOS_RELEASE_DESCRIPTION: 10452.74.0 (Official Build) beta-channel soraka)

Comment 14 by warx@chromium.org, Apr 30 2018

The culprit CL was merged to m66 by me. So we need to merge #4 in m67 and m66.

Comment 15 by warx@chromium.org, Apr 30 2018

Oh sorry. #4 is already in m67. Then we just need to merge #4 in m66.
Hey all,

Just to confirm, it looks like this made it to the M66 stable channel release (66.0.3359.137). We're seeing reports that match the behavior:

Listnr
- https://listnr.corp.google.com/report/85385787862

Community
- https://productforums.google.com/forum/#!topic/chromebook-central/zgcVxVj3zRU

Thanks!

Comment 17 by warx@chromium.org, May 2 2018

ping m66 merge approval

Comment 18 by noel@chromium.org, May 3 2018

Cc: mkarkada@chromium.org sashab@chromium.org slangley@chromium.org noel@chromium.org
 Issue 839049  has been merged into this issue.

Comment 19 by noel@chromium.org, May 3 2018

Components: Tests>Missing
Labels: -Merge-Request-66 Merge-Approved-66 M-67

Comment 21 by warx@chromium.org, May 3 2018

Issue 839456 has been merged into this issue.
Project Member

Comment 22 by bugdroid1@chromium.org, May 3 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e48779947c9d31833600112fcbf4666e740748c

commit 9e48779947c9d31833600112fcbf4666e740748c
Author: Qiang Xu <warx@google.com>
Date: Thu May 03 19:07:16 2018

m66 merge: Fix crash when the immesriv mode is enabled during initialization

This is a temp fix. It looks like it's trying to reveal first when
created, but it doesn't work that way. This could be either regression,
or wrong, and I'll look into separately.

TBR=xdai@chromium.org
TBR=oshima@chromium.org

BUG= 825260 

(cherry picked from commit 439fd0c576787f0f0e8cf4546a2c6fca05f9e592)

Change-Id: Idc605ef9f42b48b847c3bc562ebd1d9a3a0c33c6
Reviewed-on: https://chromium-review.googlesource.com/978891
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545657}
Reviewed-on: https://chromium-review.googlesource.com/1042865
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/branch-heads/3359@{#796}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/9e48779947c9d31833600112fcbf4666e740748c/ash/frame/header_view.cc

Comment 23 by warx@chromium.org, May 3 2018

Status: Fixed (was: Started)
Thanks! Fix merged to m66.

Sign in to add a comment