Files app crashes if opened in tablet mode |
|||||||||||||
Issue descriptionChrome Version: 67.0.3379.0 OS: Chrome What steps will reproduce the problem? (1) Enter tablet mode (2) Open Files app What is the expected result? Files app can be opened normally What happens instead? Chrome crashes Not sure if it also happens in earlier version of Chrome.
,
Mar 23 2018
Locally confirmed that https://chromium-review.googlesource.com/c/chromium/src/+/972677 caused this regression. Oshima, can you take a look?
,
Mar 23 2018
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/439fd0c576787f0f0e8cf4546a2c6fca05f9e592 commit 439fd0c576787f0f0e8cf4546a2c6fca05f9e592 Author: Mitsuru Oshima <oshima@chromium.org> Date: Sat Mar 24 01:39:43 2018 Fix crash when the immesriv mode is enabled during initialization This is a temp fix. It looks like it's trying to reveal first when created, but it doesn't work that way. This could be either regression, or wrong, and I'll look into separately. BUG= 825260 Change-Id: Idc605ef9f42b48b847c3bc562ebd1d9a3a0c33c6 Reviewed-on: https://chromium-review.googlesource.com/978891 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545657} [modify] https://crrev.com/439fd0c576787f0f0e8cf4546a2c6fca05f9e592/ash/frame/header_view.cc
,
Apr 3 2018
,
Apr 27 2018
Issue 837000 has been merged into this issue.
,
Apr 27 2018
The CL that caused the problem was merged (crrev.com/c/1007978) so we need to merge the fix as well.
,
Apr 30 2018
,
Apr 30 2018
this affects the camera app too
,
Apr 30 2018
warx@, could you please merge once approved?
,
Apr 30 2018
It seems like the report/regression is M67, can you confirm merge-request (c#7) is for M66 ?
,
Apr 30 2018
fwiw, i didn't see this issue when i was on M65 (Product Version: 65.0.3325.199 beta ,CHROMEOS_RELEASE_VERSION: 10323.65.0 ), but now i'm seeing this problem consistently on M66 ( 66.0.3359.137 beta, CHROMEOS_RELEASE_DESCRIPTION: 10452.74.0 (Official Build) beta-channel soraka)
,
Apr 30 2018
The culprit CL was merged to m66 by me. So we need to merge #4 in m67 and m66.
,
Apr 30 2018
Oh sorry. #4 is already in m67. Then we just need to merge #4 in m66.
,
May 2 2018
Hey all, Just to confirm, it looks like this made it to the M66 stable channel release (66.0.3359.137). We're seeing reports that match the behavior: Listnr - https://listnr.corp.google.com/report/85385787862 Community - https://productforums.google.com/forum/#!topic/chromebook-central/zgcVxVj3zRU Thanks!
,
May 2 2018
ping m66 merge approval
,
May 3 2018
Issue 839049 has been merged into this issue.
,
May 3 2018
,
May 3 2018
,
May 3 2018
Issue 839456 has been merged into this issue.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e48779947c9d31833600112fcbf4666e740748c commit 9e48779947c9d31833600112fcbf4666e740748c Author: Qiang Xu <warx@google.com> Date: Thu May 03 19:07:16 2018 m66 merge: Fix crash when the immesriv mode is enabled during initialization This is a temp fix. It looks like it's trying to reveal first when created, but it doesn't work that way. This could be either regression, or wrong, and I'll look into separately. TBR=xdai@chromium.org TBR=oshima@chromium.org BUG= 825260 (cherry picked from commit 439fd0c576787f0f0e8cf4546a2c6fca05f9e592) Change-Id: Idc605ef9f42b48b847c3bc562ebd1d9a3a0c33c6 Reviewed-on: https://chromium-review.googlesource.com/978891 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545657} Reviewed-on: https://chromium-review.googlesource.com/1042865 Reviewed-by: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/branch-heads/3359@{#796} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/9e48779947c9d31833600112fcbf4666e740748c/ash/frame/header_view.cc
,
May 3 2018
Thanks! Fix merged to m66. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by x...@chromium.org
, Mar 23 2018