Not possible to exclude just content/browser:browser with jumbo_build_excluded |
|||
Issue descriptionThe gn variable jumbo_build_excluded can be used to exclude targets from jumbo by name, if you prefer to compile them locally. Unfortunately some names are common, such as "browser", so if you exclude "browser" you lost jumbo all over the place. It would be good to be able to exclude with a more targetted approach (as well), but I can't find any getter with the short, specific name. The closest are get_label_info(target_name, "dir") which returns "content/browser/browser" and get_label_info(target_name, "label_no_toolchain") which returns "content/browser/browser:browser" Would it be possible to add another get_label_info flavor that returns "content/browser:browser", like you would write in a gn file?
,
Mar 23 2018
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b48eb3e9773fc092799a559bb3064176deaa99 commit 85b48eb3e9773fc092799a559bb3064176deaa99 Author: Daniel Bratell <bratell@opera.com> Date: Thu Nov 08 13:03:54 2018 Make it easier to surgically exclude targets from jumbo Currently disabling jumbo for a build target in a local build means that you also disable jumbo for all other targets with the same local name, and giving a fully qualified label as name won't work at all. This patch changes the matching to be more flexible so that you can supply both a local name (as before) but also a full path or qualified name like //third_party/blink/renderer/core/svg:svg Bug: 825240 Change-Id: I706e4d7c3f863a7996e576d36ddd62ac81b8cb12 Reviewed-on: https://chromium-review.googlesource.com/c/1323110 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#606433} [modify] https://crrev.com/85b48eb3e9773fc092799a559bb3064176deaa99/build/config/jumbo.gni
,
Nov 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by brat...@opera.com
, Mar 23 2018