Do not send default port number in WebSocket over HTTP/2 request |
||
Issue description
A typical WebSocket over HTTP/2 request currently looks like this:
t=24662 [st=20887] HTTP2_SESSION_SEND_HEADERS
--> exclusive = true
--> fin = false
--> has_priority = true
--> :method: CONNECT
:authority: nghttp2.org:443
:scheme: https
:path: /echo
:protocol: websocket
pragma: no-cache
cache-control: no-cache
origin: https://nghttp2.org
sec-websocket-version: 13
user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3377.1 Safari/537.36
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9,hu;q=0.8
sec-websocket-extensions: permessage-deflate; client_max_window_bits
--> parent_stream_id = 0
--> source_dependency = 13707 (URL_REQUEST)
--> stream_id = 15
--> weight = 147
However, since 443 is the default port for https, there is no need to explicitly include this.
Also see
https://lists.w3.org/Archives/Public/ietf-http-wg/2018JanMar/0189.html
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04773c9eb9f935b027e7489fd2c2ca8bda9b8355 commit 04773c9eb9f935b027e7489fd2c2ca8bda9b8355 Author: Bence Béky <bnc@chromium.org> Date: Tue Mar 27 03:23:56 2018 Do not send default port number in WebSocket over HTTP/2 request. Also add some unrelated test expectations. Bug: 825231 Change-Id: I04c26e6ddd7ab2ad340ab8dd6f333d5589547a73 Reviewed-on: https://chromium-review.googlesource.com/979092 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545960} [modify] https://crrev.com/04773c9eb9f935b027e7489fd2c2ca8bda9b8355/net/spdy/chromium/spdy_http_utils.cc [modify] https://crrev.com/04773c9eb9f935b027e7489fd2c2ca8bda9b8355/net/spdy/chromium/spdy_network_transaction_unittest.cc [modify] https://crrev.com/04773c9eb9f935b027e7489fd2c2ca8bda9b8355/net/websockets/websocket_handshake_stream_create_helper_test.cc [modify] https://crrev.com/04773c9eb9f935b027e7489fd2c2ca8bda9b8355/net/websockets/websocket_stream_test.cc
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19afcd650e0dcf198e4afa936426f84c4f7c93cf commit 19afcd650e0dcf198e4afa936426f84c4f7c93cf Author: Bence Béky <bnc@chromium.org> Date: Tue Mar 27 12:04:16 2018 Remove unnecessary test method arguments. In websocket_stream_test.cc, test methods take URL, host (with optional port), and path arguments, which are redundant. This CL removes the host and path arguments and generates them from URL. Also, every test uses the same origin and host_for_cookies, therefore there is no need to pass those as arguments either. Bug: 825231 Change-Id: I31c0c7a44e3e0d28d10c5b1b0c61b2fc744c7e48 Reviewed-on: https://chromium-review.googlesource.com/980958 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#546083} [modify] https://crrev.com/19afcd650e0dcf198e4afa936426f84c4f7c93cf/net/websockets/websocket_stream_test.cc
,
Mar 27 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by b...@chromium.org
, Mar 23 2018