editing/composition-underline-color.html Failing on WebKit Win10 |
|||||
Issue descriptionFirst observed to fail on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32584
,
Mar 23 2018
Removing from the sheriff queue. There is no obvious owner for this, so I'm leaving it to the triage of Blink>Editing
,
Mar 23 2018
Assigning to rego@igalia.com since I think this is related to this CL: https://chromium-review.googlesource.com/c/chromium/src/+/602355 The Windows 10 test probably needs to be rebaselined.
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/019b022180aed4515297767dfe9a686055cd4c01 commit 019b022180aed4515297767dfe9a686055cd4c01 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Mar 23 14:50:31 2018 Disable editing/composition-underline-color.html on Win10 Bug: 825209 No-Try: true No-Presubmit: true Change-Id: I9d77fd7fcc21285a8f5107908b9439985edbd29e Reviewed-on: https://chromium-review.googlesource.com/978220 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#545442} [modify] https://crrev.com/019b022180aed4515297767dfe9a686055cd4c01/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 26 2018
> The Windows 10 test probably needs to be rebaselined. Yes, it seems that's the issue. Dunno why it wasn't caught on the original CL by the tryjobs (it seems win10_chromium_x64_rel_ng is not running the tests, but win10_blink_rel is doing it). Anyway the change is pretty simple, as both Win7 and Win10 will share the same baseline: https://chromium-review.googlesource.com/c/chromium/src/+/979793/
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a147393b7dbde9969c8b1836d7a95da67dccbf88 commit a147393b7dbde9969c8b1836d7a95da67dccbf88 Author: Manuel Rego Casasnovas <rego@igalia.com> Date: Mon Mar 26 15:30:47 2018 Enable editing/composition-underline-color.html on Win10 Update the baseline for Windows platform. BUG= 554893 , 825209 Change-Id: Iea34acced865105aabb11b1bce804c454bbd01f7 Reviewed-on: https://chromium-review.googlesource.com/979793 Reviewed-by: Ryan Landay <rlanday@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#545796} [modify] https://crrev.com/a147393b7dbde9969c8b1836d7a95da67dccbf88/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a147393b7dbde9969c8b1836d7a95da67dccbf88/third_party/WebKit/LayoutTests/platform/win/editing/composition-underline-color-expected.txt [delete] https://crrev.com/0d5e363089648f237f01341b28143fb27f5261f3/third_party/WebKit/LayoutTests/platform/win7/editing/composition-underline-color-expected.txt
,
Mar 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cfroussios@chromium.org
, Mar 23 2018