New issue
Advanced search Search tips

Issue 825203 link

Starred by 2 users
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Text elements have lower edge clipped by at least one pixel

Project Member Reported by cjgrant@chromium.org, Mar 23 2018 
Many VR text elements have the bottom edge clipped off.  Ie, letters like g or y are missing bits.

This might apply only to "fixed height" elements.

We need to review how text textures are generated.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea054724cb0ed49de394ffd316dc56d377302eb

commit 9ea054724cb0ed49de394ffd316dc56d377302eb
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Mar 27 20:18:31 2018

VR: Fix single-line text clipping on bottom edge

BUG= 825203 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I06bd09f0c0599756541ac0ce1077e7275fe41a64
Reviewed-on: https://chromium-review.googlesource.com/981295
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546230}
[modify] https://crrev.com/9ea054724cb0ed49de394ffd316dc56d377302eb/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/9ea054724cb0ed49de394ffd316dc56d377302eb/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/9ea054724cb0ed49de394ffd316dc56d377302eb/chrome/browser/vr/ui_scene_creator.cc

Comment 2 by cjgrant@chromium.org, Mar 27 2018

Status: Fixed (was: Assigned)

Comment 3 by dougman@chromium.org, Apr 5 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified on build 67.0.3389.0 canary.  Looks good.
►

Sign in to add a comment