New issue
Advanced search Search tips

Issue 825195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

shouldOverrideUrlLoading java exceptions are not consistently propagated back to the application

Project Member Reported by tobiasjs@chromium.org, Mar 23 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dc609409db1135769fa568af2f3c60d72b714c6

commit 8dc609409db1135769fa568af2f3c60d72b714c6
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Wed Mar 28 15:06:41 2018

aw: Fix shouldOverrideUrlLoading exception propagation regression.

PlzNavigate added another JNI call that occurs from
content::NavigationRequest::OnRequestFailed after the exception
caused in the shouldOverrideUrlLoading call. It's not legal to call
into Java with an uncleared exception, and the second call isn't
unchecked either. so the Java exception is turned into a native
crash. This CL makes sure that we exit back to the event loop, and
also adds a test that shouldOverrideUrlLoading exceptions make it
back to the UI thread.

Bug:  825195 
Change-Id: I447f7feecf45cd1d6cd94f7af16bb64e0a1c43b5
Reviewed-on: https://chromium-review.googlesource.com/966823
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546486}
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/android_webview/browser/aw_contents_client_bridge.cc
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/android_webview/browser/aw_contents_client_bridge.h
[add] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/android_webview/javatests/src/org/chromium/android_webview/test/AwUncaughtExceptionTest.java
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/android_webview/test/BUILD.gn
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/8dc609409db1135769fa568af2f3c60d72b714c6/content/public/browser/content_browser_client.h

Status: Fixed (was: Assigned)

Sign in to add a comment