New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 825191 link

Starred by 1 user
Status: Fixed
Owner:
robertma@chromium.org
Closed: Mar 2018
Cc:
█ bsittler@chromium.org
jsb...@chromium.org
robertma@chromium.org
foolip@chromium.org
pwnall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT] Many IDL tests are broken by import https://crrev.com/c/978021

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Mar 23 2018 
WPT import https://crrev.com/c/978021 introduced new failures in external/wpt/cookie-store:

List of new failures:
external/wpt/cookie-store/idlharness.tentative.html new failing tests: https://crrev.com/c/978021/4/third_party/WebKit/LayoutTests/external/wpt/cookie-store/idlharness.tentative-expected.txt

This import contains upstream changes from e40c752465ac7413cf0212bed504ee0098dbd6a9 to 20d739eff6ebfe360c1aadfd3f3161c0fce847a2:
Add HTMLOrSVGElement to HTML's IDL: https://github.com/w3c/web-platform-tests/commit/20d739eff6ebfe360c1aadfd3f3161c0fce847a2

Comment 1 by robertma@chromium.org, Mar 23 2018

Cc: jsb...@chromium.org
 Issue 825192  has been merged into this issue.

Comment 2 by robertma@chromium.org, Mar 23 2018

Labels: Test-Layout Pri-1 Type-Bug
Owner: robertma@chromium.org
Status: Started (was: Untriaged)
Summary: [WPT] Many IDL tests are broken by import https://crrev.com/c/978021 (was: [WPT] New failures introduced in external/wpt/cookie-store by import https://crrev.com/c/978021)
html.idl was changed by https://github.com/w3c/web-platform-tests/pull/10110

foolip's comment: So tests that include html.idl will now have to either define 'interface SVGElement {};' or import svg.idl.

Many IDL test that includes html.idl are currently broken. Looking for a fix.

Comment 3 by robertma@chromium.org, Mar 23 2018

Cc: foolip@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f614471ab4ad066c6f829000cc878461795bd2a

commit 5f614471ab4ad066c6f829000cc878461795bd2a
Author: Robert Ma <robertma@chromium.org>
Date: Fri Mar 23 22:04:26 2018

Fix some IDL tests after html.idl includes SVGElement

html.idl changed in upstream
https://github.com/w3c/web-platform-tests/pull/10110
and imported in
https://crrev.com/c/978021

Bug:  825191 
Change-Id: Ie1a04e730aabd50c615f1dab079f92eeaa22565a
Reviewed-on: https://chromium-review.googlesource.com/978508
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545588}
[delete] https://crrev.com/c1b2fa29a209ccb642a20c53b9fc04a3b69b656c/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interfaces.any-expected.txt
[modify] https://crrev.com/5f614471ab4ad066c6f829000cc878461795bd2a/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interfaces.any.js
[delete] https://crrev.com/c1b2fa29a209ccb642a20c53b9fc04a3b69b656c/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interfaces.any.worker-expected.txt
[delete] https://crrev.com/c1b2fa29a209ccb642a20c53b9fc04a3b69b656c/third_party/WebKit/LayoutTests/external/wpt/cookie-store/idlharness.tentative-expected.txt
[modify] https://crrev.com/5f614471ab4ad066c6f829000cc878461795bd2a/third_party/WebKit/LayoutTests/external/wpt/cookie-store/idlharness.tentative.html
[modify] https://crrev.com/5f614471ab4ad066c6f829000cc878461795bd2a/third_party/WebKit/LayoutTests/external/wpt/hr-time/idlharness-expected.txt
[modify] https://crrev.com/5f614471ab4ad066c6f829000cc878461795bd2a/third_party/WebKit/LayoutTests/external/wpt/hr-time/idlharness.html
[modify] https://crrev.com/5f614471ab4ad066c6f829000cc878461795bd2a/third_party/WebKit/LayoutTests/external/wpt/webaudio/idlharness.https-expected.txt
[modify] https://crrev.com/5f614471ab4ad066c6f829000cc878461795bd2a/third_party/WebKit/LayoutTests/external/wpt/webaudio/idlharness.https.html

Comment 5 by robertma@chromium.org, Mar 23 2018

Components: Blink>Infra>Ecosystem
Status: Fixed (was: Started)
►

Sign in to add a comment