CSS shadow editor allow spread in text-shadows
Reported by
ugobaron...@gmail.com,
Mar 23 2018
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Steps to reproduce the problem: 1. Open Chrome on any page with text and text-shadows + like this one https://www.w3schools.com/css/css3_shadows.asp 2. use the DevTools to inspect any text with shadows on the page 3. in the "Elements" tab, open the "Styles" sub-section 4. locate the "text-shadow" property in the element's CSS 5. click the "shadow editor" for the text-shadow 6. add any amount of spread to the text-shadow What is the expected behavior? The spread value should not be added to the text-shadow, and the spread slider should be disabled. What went wrong? The spread value is added to the text-shadow, making it invalid CSS and removing the shadow. Did this work before? N/A Chrome version: 64.0.3282.186 Channel: n/a OS Version: OS X 10.13.3 Flash Version: Italian UI
,
Aug 15
,
Aug 16
,
Aug 24
Hey! I think, this looks like a good first issue; I would like to work on it.
,
Aug 27
I've submitted a CL: https://chromium-review.googlesource.com/c/chromium/src/+/1188939
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdc316d01c1227032bb2583501989bd83244ed18 commit fdc316d01c1227032bb2583501989bd83244ed18 Author: ergunsh <erdogmusergun@gmail.com> Date: Tue Aug 28 21:56:30 2018 DevTools: fix showing type and spread when shadow editor not opened for box shadow Bug: 825185 Change-Id: I1d17095fcf1808da1966a65af67e83a006907722 Reviewed-on: https://chromium-review.googlesource.com/1188939 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#586872} [modify] https://crrev.com/fdc316d01c1227032bb2583501989bd83244ed18/AUTHORS [modify] https://crrev.com/fdc316d01c1227032bb2583501989bd83244ed18/third_party/blink/renderer/devtools/front_end/inline_editor/CSSShadowEditor.js
,
Aug 28
Thank you for the contribution!
,
Aug 30
Tested the issue on build without fix #64.0.3282.186 and with fix #70.0.3537.0 using Mac OS 10.13.6 by following the steps as per comment#0. Attached screenshots of both with fix and without fix as reference. erdogmusergun@ : Could you please review the screenshots and help us in verifying the fix. Thanks.!
,
Aug 31
The fix is correct! Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by eostroukhov@chromium.org
, Mar 23 2018Status: Assigned (was: Unconfirmed)