New issue
Advanced search Search tips

Issue 825184 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"Web Inspector" reports "Error" instead of "Warning" for "Input" element with Same ids

Reported by piyushth...@gmail.com, Mar 23 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
1. I had two div containing same input element one for mobile device one for big screens.
2. The "Web Inspector" reports "Error" in "console" instead of "Warning" for these "Input" having same ids 

What is the expected behavior?
The "Web Inspector" should show "warnings" for this thing instead of "Error", as this Thing is common for developers who develop two version fro Mobile and desktops. 

What went wrong?
As My Product is Old and same approach is been used from around 5 Years by my development team, I am Frustrated with this issue, because no other browser shows this thing except Chrome. This is not only in my case other developers are also chocked by this. Please provide a solution for this.

Did this work before? N/A 

Chrome version: 65.0.3325.181  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Please provide a solution for this.
 
duplicateid.png
118 KB View Download

Comment 1 by ajha@chromium.org, Mar 26 2018

Labels: Needs-Triage-M65
Cc: vamshi.kommuri@chromium.org
Labels: Triaged-ET Needs-Feedback
Thanks for filing the issue!

@Reporter: Could you please share a sample test file/URL which helps us to triage the issue in a better way. Any further inputs from your end may helps us. 
Hi, thanks for your feedback, I can't attach a file or provide you the Url, as the url and files are confidential, the only thing I can help you is that this error is reported when a Page contains two different "Inputs, select or form" with same "id". for example If a web-page contains "Form-A" and "For-B" and both has same "id=webForm" then, "Chrome" reports an error "[DOM] Found 2 elements with non-unique id #webForm: (More info: https://goo.gl/9p2vKq)". In this scenario "chrome" should provide a warning message not an Error.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 26 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by kozy@chromium.org, Mar 30 2018

Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Hi vamshi.kommuri@chromium.org is there any update on this Bug.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf2c755712eaf4fe975b5e9ac7b92155c0d3ce7e

commit bf2c755712eaf4fe975b5e9ac7b92155c0d3ce7e
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 19 08:36:45 2018

DevTools: duplicate-id errors should be warnings

Password manager may analyze a page and report errors to DevTools:
"[DOM] Found N elements with non-unique id#id: (More info:...)"

This CL changes the level to warning, since duplicates do not
break execution flow.

Bug:  825184 
Change-Id: Ia7bb544f712e14bc99a7fdf7d912fa70c2a4d5c7
Reviewed-on: https://chromium-review.googlesource.com/c/1064978
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601080}
[modify] https://crrev.com/bf2c755712eaf4fe975b5e9ac7b92155c0d3ce7e/chrome/renderer/autofill/page_passwords_analyser_browsertest.cc
[modify] https://crrev.com/bf2c755712eaf4fe975b5e9ac7b92155c0d3ce7e/components/autofill/content/renderer/page_passwords_analyser.cc

Status: Fixed (was: Assigned)

Sign in to add a comment