[Dice M2] Signin tab does not reuse NTP |
||
Issue descriptionIn other cases there is logic to reuse an existing NTP tab when showing the signin tab. Dice does not do this. This causes failures in tests when enabling dice by default (bookmark_bubble_sign_in_delegate_browsertest.cc).
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd3c8fe80c974a5c724ab2711c0f0099c1960a22 commit dd3c8fe80c974a5c724ab2711c0f0099c1960a22 Author: David Roger <droger@chromium.org> Date: Thu Mar 29 08:03:27 2018 [Dice] Reuse existing NTP for signin This logic existed pre-dice, and was not ported to Dice. This is required to enable Dice by default in all tests. Bug: 825173 Change-Id: If3e4c7a0aebbb735be45875342d66a5436ef5f35 Reviewed-on: https://chromium-review.googlesource.com/980172 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#546764} [modify] https://crrev.com/dd3c8fe80c974a5c724ab2711c0f0099c1960a22/chrome/browser/ui/signin_view_controller.cc [modify] https://crrev.com/dd3c8fe80c974a5c724ab2711c0f0099c1960a22/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
,
Mar 29 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by droger@chromium.org
, Mar 23 2018