NOTE:
Issue is seen for couple of extension like google calendar ,gmail checker.
Issue is reproducible where extension have sub-listing below extension icon.

It also looks like that buttons and the hover buttons are 2px too low and the rounded corners are missing at the bottom.

+StableBlocker since this is a regression.

Deleted: actual_vs_expected.png 31.1 KB

	actual_vs_expected.png 31.1 KB View Download

+pkasting@ FYI. Also +tapted@ since I don't work on Mac. I will look into how my CL introduced this regression.

For this bug, the problematic line is https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm?q=browser_actions_controller.mm&sq=package:chromium&l=426

In particular using 0 as the Y coordinate. I think what we need to do here is something like:

const int y = (NSMaxY([containerView_ bounds]) - size.height()) / 2;


Sorry, I'm not familiar with mac, and I don't have a way to test a fix on it. Can you please fix this, and incorporate it with  bug 792593 ? Thanks!

 Issue 827629  has been merged into this issue.

M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49783590381be882d3097a0f13f00d3f67858c4d

commit 49783590381be882d3097a0f13f00d3f67858c4d
Author: spqchan <spqchan@chromium.org>
Date: Wed May 02 16:51:14 2018

[Mac] Fix for Extension Icon Chopped Entries

The button actions container logic was recently refactored so that
the padding is now baked inside the extension icon view bounds:
https://chromium-review.googlesource.com/c/chromium/src/+/961722

This caused the extension icons to be chopped because it conflicts
with the existing code that sets the vertical padding and height in
the browser action container. This causes icon to have an incorrect
y offset.

This CL fixes the issue by removing the browser action container's
padding logic, since that is now done by the extension icon view.

Bug:  825157 
Change-Id: I43a4ca55fba1af0aba9ead7279a74819ba04f0d9
Reviewed-on: https://chromium-review.googlesource.com/1037764
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555428}
[modify] https://crrev.com/49783590381be882d3097a0f13f00d3f67858c4d/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.

Update : 
Retested above issue in latest Canary build #68.0.3418.0 on Mac(10.12.6, 10.13.1, 10.13.5) OS and the issue is fixed. Entries appears completely. Kindly review an attached screen-cast.

Thank you.!

Deleted: Canary_Behaviour#68.0.3418.0.mov 2.3 MB

	Canary_Behaviour#68.0.3418.0.mov 2.3 MB View Download

This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

How is the change listed at #8 looking in canary? Is it safe to merge now?

The change looks okay on mac. It should be safe to merge. The CL is also low risk

Approving merge to M67 branch 3396 based on comment #10 and #14. Please merge ASAP.

Also pls mark the bug as fixed after the merge if nothing else is pending. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/006a31540fdeacd7a6557b02b7244d7864c3935e

commit 006a31540fdeacd7a6557b02b7244d7864c3935e
Author: spqchan <spqchan@chromium.org>
Date: Thu May 03 23:00:38 2018

[Mac] Fix for Extension Icon Chopped Entries

The button actions container logic was recently refactored so that
the padding is now baked inside the extension icon view bounds:
https://chromium-review.googlesource.com/c/chromium/src/+/961722

This caused the extension icons to be chopped because it conflicts
with the existing code that sets the vertical padding and height in
the browser action container. This causes icon to have an incorrect
y offset.

This CL fixes the issue by removing the browser action container's
padding logic, since that is now done by the extension icon view.

(cherry picked from commit 49783590381be882d3097a0f13f00d3f67858c4d)

Bug:  825157 
Change-Id: I43a4ca55fba1af0aba9ead7279a74819ba04f0d9
Reviewed-on: https://chromium-review.googlesource.com/1037764
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555428}
Reviewed-on: https://chromium-review.googlesource.com/1043281
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#467}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/006a31540fdeacd7a6557b02b7244d7864c3935e/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Update : 
Retested above issue in Beta build #67.0.3396.40 on  Mac(10.12.6,10.13.1,10.13.5) OS and the issue is fixed. Chopped entries are seen completely. Kindly review an attached screen-cast from drive link(https://drive.google.com/open?id=1oyGoCpz_uQSzTJPPMcQgIecboTXoO_RI).

Thank you..!