The tests are mostly failing on waterfall. I'm going to revert the suspects.

I have reverted https://chromium.googlesource.com/chromium/src/+/d3711b44bcb0cfdab5b0189a064c212e0d1d398f
I don't know why the bot hasn't commented on this bug

Reverting did not fix it. Undoing the revert...

Findit believes this to be the culprit https://chromium-review.googlesource.com/c/chromium/src/+/974201

I will revert and observe.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1873470733c8d03858c38e964897bfa65ea6e055

commit 1873470733c8d03858c38e964897bfa65ea6e055
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Mar 23 09:57:58 2018

Revert "Switch MHTML generation to the new callbacks."

This reverts commit d3711b44bcb0cfdab5b0189a064c212e0d1d398f.

Reason for revert: suspected of making BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestWithDownloadsFromDifferentProfiles/ very flaky on waterfall

Original change's description:
> Switch MHTML generation to the new callbacks.
> 
> BUG=714018
> 
> Change-Id: I33cd6842055c959af25e286b1962c6f902b35971
> Reviewed-on: https://chromium-review.googlesource.com/974284
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545087}

TBR=avi@chromium.org,jam@chromium.org

Change-Id: I0ed09e0d0322de613180e5b7558256fb3aea58bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018,  825141 
Reviewed-on: https://chromium-review.googlesource.com/977981
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545395}
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/mhtml_generation_manager.h
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/save_package.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/public/browser/web_contents.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c7f7c20ff62410f18023812ed6e1a61302f4158

commit 7c7f7c20ff62410f18023812ed6e1a61302f4158
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Mar 23 14:36:16 2018

Revert "Reland "Turn on native notifications by default for Chrome OS.""

This reverts commit ecf455beb757f0b94d6dd63ee587669bb1842a09.

Reason for revert: Suspected of making BrowserCloseManagerWithDownloadsBrowserTest/BrowserClose
anagerWithDownloadsBrowserTest.TestWithDownloadsFromDifferentProfiles/
flaky on Asan
e.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/26690

Original change's description:
> Reland "Turn on native notifications by default for Chrome OS."
> 
> This is a reland of 8ce1863fca7917a12da14951cffafa0f7917a668
> 
> MSan fix was landed as 522e7d296fe445ccea4020789
> 
> Original change's description:
> > Turn on native notifications by default for Chrome OS.
> >
> > They're already on by default for Mash. This makes Chrome use the mojo
> > ("native") interface for notifications even in non-Mash.
> >
> > Bug:  578868 
> > Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b
> > Reviewed-on: https://chromium-review.googlesource.com/963518
> > Commit-Queue: Evan Stade <estade@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#544395}
> 
> Bug:  578868 
> Change-Id: Idac45274aaea709ef910d4bcb20b14f9a05a952c
> Reviewed-on: https://chromium-review.googlesource.com/974201
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545113}

TBR=stevenjb@chromium.org,sky@chromium.org,estade@chromium.org

Change-Id: I8e0e903703cf2d3ca76fe69092bd3029ed0a16f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  578868 ,  825141 
Reviewed-on: https://chromium-review.googlesource.com/977908
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545439}
[modify] https://crrev.com/7c7f7c20ff62410f18023812ed6e1a61302f4158/chrome/common/chrome_features.cc

The flake *seems* better (more data points from https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 pending).

+estade
I'm optimistically assigning to the owner of the reverted CL. Please take a look and confirm if your CL was indeed to blame

yea, I was to blame. Marking this started so it can track fixing the root cause before trying to re-land that change.

Removing label to get out of sheriff queue.

 Issue 824000  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/661500f04972a24780cbcf5bed13f9a8c315e102

commit 661500f04972a24780cbcf5bed13f9a8c315e102
Author: Evan Stade <estade@chromium.org>
Date: Thu Apr 05 18:08:48 2018

Mash notifications: fix handling of out-of-order Display/Close pairs.

The linked bug uncovered a case where ShowClientNotification was called
multiple times with the same notification (i.e. the same notification
ID) on the Chrome side, while Ash sent a HandleNotificationClosed
for the first shown notification which arrived in Chrome after the
second ShowClientNotification. Then Ash subsequently sent a second
HandleNotificationClosed, but since the notification had already been
removed from the Chrome-side cache in response to the first
HandleNotificationClosed, an error was thrown (specifically, the check
in NotificationPlatformBridgeChromeOs::HandleNotificationClosed()).

The solution is to create a token that is separate from the
notification's ID to identify the Display call to which the Close is
paired. This token is not used for other callbacks, such as the button
handlers, because then Chrome could drop user input that occurred around
the same time as a notification being updated (seems fairly likely for
any notification that has a progress bar, such as downloads).

Bug:  825141 
Change-Id: I01f66dcc1107bfa7337c447780edb897e24498e6
Reviewed-on: https://chromium-review.googlesource.com/979268
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548484}
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/ash/message_center/message_center_controller.cc
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/ash/message_center/message_center_controller.h
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/ash/message_center/notifier_settings_view_unittest.cc
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/ash/public/interfaces/ash_message_center_controller.mojom
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/chrome/browser/notifications/chrome_ash_message_center_client.cc
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/chrome/browser/notifications/chrome_ash_message_center_client.h
[add] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/chrome/browser/notifications/chrome_ash_message_center_client_browsertest.cc
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/chrome/browser/notifications/notification_platform_bridge_chromeos.cc
[modify] https://crrev.com/661500f04972a24780cbcf5bed13f9a8c315e102/chrome/test/BUILD.gn

Findit identified the culprit r544395 with confidence 70.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVytQILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCL-AWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI2NjY0L2Jyb3dzZXJfdGVzdHMvUW5KdmQzTmxja05zYjNObFRXRnVZV2RsY2xkcGRHaEViM2R1Ykc5aFpITkNjbTkzYzJWeVZHVnpkQzlDY205M2MyVnlRMnh2YzJWTllXNWhaMlZ5VjJsMGFFUnZkMjVzYjJGa2MwSnliM2R6WlhKVVpYTjBMbFJsYzNSWGFYUm9UMlptVkdobFVtVmpiM0prVjJsdVpHOTNRVzVrVW1WbmRXeGhja1J2ZDI1c2IyRmtMekU9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAww


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

r544395 was reverted