New issue
Advanced search Search tips

Issue 825133 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 726621



Sign in to add a comment

[Picture-in-Picture] Hide button if Android device doesn't support PiP at all.

Project Member Reported by fbeaufort@chromium.org, Mar 23 2018

Issue description

Android Oreo devices (1.1% at the moment) are the only Android devices to support Picture-in-Picture.
I think we should hide (not disable) Picture-in-Picture button for Android N and below that don't support it.
 
Labels: M-69
Don't we already do that when PIP isn't supported?
Mocks say PiP overflow menu can be hidden AND disabled. For now, we only hide this control if SupportsPictureInPicture returns false. 

As you can see below, we should update this to check when Picture-in-Picture is not available (Android N) AND when it is simply disabled (disablePictureInPicture, feature policy, metadata not loaded, audio-file, etc.)


bool HTMLVideoElement::SupportsPictureInPicture() const {
  return PictureInPictureController::From(GetDocument())
             .IsElementAllowed(*this) ==
         PictureInPictureController::Status::kEnabled;
}
Status: WontFix (was: Available)
Closing given that that's what we do today.

Sign in to add a comment