[Picture-in-Picture] Hide button if Android device doesn't support PiP at all. |
||
Issue descriptionAndroid Oreo devices (1.1% at the moment) are the only Android devices to support Picture-in-Picture. I think we should hide (not disable) Picture-in-Picture button for Android N and below that don't support it.
,
May 31 2018
Mocks say PiP overflow menu can be hidden AND disabled. For now, we only hide this control if SupportsPictureInPicture returns false.
As you can see below, we should update this to check when Picture-in-Picture is not available (Android N) AND when it is simply disabled (disablePictureInPicture, feature policy, metadata not loaded, audio-file, etc.)
bool HTMLVideoElement::SupportsPictureInPicture() const {
return PictureInPictureController::From(GetDocument())
.IsElementAllowed(*this) ==
PictureInPictureController::Status::kEnabled;
}
,
Jun 22 2018
Closing given that that's what we do today. |
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, May 31 2018