New issue
Advanced search Search tips

Issue 825127 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ComputedStyle::Clone

Project Member Reported by ClusterFuzz, Mar 23 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6023384794923008

Fuzzer: ochang_domfuzzer
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::ComputedStyle::Clone
  blink::StyleResolver::CreateAnimatableValueSnapshot
  blink::StringKeyframe::CSSPropertySpecificKeyframe::PopulateAnimatableValue
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=535692:535694

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6023384794923008

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 23 2018

Components: Blink>Animation Blink>CSS
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Components: -Blink>CSS -Blink>Animation Internals>Compositing>Animation
Status: Available (was: Untriaged)
Confirm that it crashes with content_shell --run-layout-test. Does not happen without --run-layout-test. DCHECK failure before the crash for Platform::Current()->IsThreadedAnimationEnabled().

Comment 3 by flackr@chromium.org, Mar 23 2018

Owner: smcgruer@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by ClusterFuzz, Mar 24 2018

Labels: OS-Windows
Cc: majidvp@chromium.org
Status: Started (was: Assigned)
I'm assuming this is just because WorkletAnimation::Create doesn't actually check for threaded animations being enabled. Should be an easy fix if so.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697401b488b694d2dafc6e1545752d1c2b3e7a39

commit 697401b488b694d2dafc6e1545752d1c2b3e7a39
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Mar 26 17:12:23 2018

AnimationWorklet: Check for threaded animations before constructing a WorkletAnimation

This avoids hitting the DCHECK in WorkletAnimation::WorkletAnimation in
the case where --disable-threaded-animations is specified.

Bug:  825127 
Change-Id: I5e2eb0684e472d5a88f40ad07f19f73c0118b627
Reviewed-on: https://chromium-review.googlesource.com/980234
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545824}
[modify] https://crrev.com/697401b488b694d2dafc6e1545752d1c2b3e7a39/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.cpp

Project Member

Comment 7 by ClusterFuzz, Mar 27 2018

ClusterFuzz has detected this issue as fixed in range 545823:545824.

Detailed report: https://clusterfuzz.com/testcase?key=6023384794923008

Fuzzer: ochang_domfuzzer
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::ComputedStyle::Clone
  blink::StyleResolver::CreateAnimatableValueSnapshot
  blink::StringKeyframe::CSSPropertySpecificKeyframe::PopulateAnimatableValue
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=535692:535694
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=545823:545824

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6023384794923008

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Mar 27 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6023384794923008 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment