New issue
Advanced search Search tips

Issue 825119 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Improper context menu appears from second right click on chrome://bookmarks page.

Reported by khushal....@etouch.net, Mar 23 2018 
Chrome Version: 67.0.3379.0 (Official Build) Revision: 1a1fb435932e9d87bebcdb0a0b2c5e2f3de3a694-refs/heads/master@{#545319} (32/64-bit)
 	
OS: Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.4), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://bookmarks page.
2. Now right click on bookmarks page multiple times and observe.

Actual Result: Improper context menu (back, forward, print,...) appears from second right click on chrome://bookmarks page.
Expected Result: Proper context menu ("Add new bookmark" and "Add new folder") should appear on every right click.

This is a regression issue, broken in M-67 series, and will soon update other info.

Good Build: 67.0.3372.0
Bad Build:  67.0.3373.0

Thank You!
Actual Video.mp4
516 KB View Download
Expected Video.mp4
408 KB View Download

Comment 1 by khushal....@etouch.net, Mar 23 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)

This is a regression issue, broken in M-67 series, using the per-revision bisect providing the bisect results,

Good Build: 67.0.3372.0 (Revision: 543593)
Bad Build:  67.0.3373.0 (Revision: 543879)

You are probably looking for a change made after 543615 (known good), but no later than 543616 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b35d9a7018b2e7ea651518411978e2bd93b46729..42944a0ed387ac5ada7af465cc20655aad417d19

Suspect: https://chromium.googlesource.com/chromium/src/+/42944a0ed387ac5ada7af465cc20655aad417d19

@calamity: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: This issue is also seen M-67 Dev (build #67.0.3377.0).
   
Thank You!
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65fe25c3fc67dcbde36de3f4daf67ec374f3020

commit f65fe25c3fc67dcbde36de3f4daf67ec374f3020
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Apr 18 08:59:49 2018

[MD Bookmarks] Fix right-click showing browser context menu.

This CL fixes an issue where the right-click of a bookmark item wouldn't show a
new command menu when a command menu was already open. This was caused by the
mousedown on the original menu not closing the menu.

When cr-action-menu changed to no longer be a type extension, the event was no
longer fired by the dropdown itself, and rather a child. This CL changes the
event expectation so that the menu will close correctly.

Bug:  825119 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1cd5494c7208b21d55f817303389bb845794458e
Reviewed-on: https://chromium-review.googlesource.com/1013769
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551615}
[modify] https://crrev.com/f65fe25c3fc67dcbde36de3f4daf67ec374f3020/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/f65fe25c3fc67dcbde36de3f4daf67ec374f3020/chrome/test/data/webui/md_bookmarks/command_manager_test.js

Comment 3 by calamity@chromium.org, Apr 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment