New issue
Advanced search Search tips

Issue 825094 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 803853



Sign in to add a comment

Rename WebFrameScheduler to FrameScheduler

Project Member Reported by yutak@chromium.org, Mar 23 2018

Issue description

(Part of Scheduler Architecture 2.0: issue 803853)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0144aa846ddecbedcc5123cb3772623527d37c8b

commit 0144aa846ddecbedcc5123cb3772623527d37c8b
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Mar 26 10:34:32 2018

Rename WebFrameScheduler to FrameScheduler.

This patch drops "Web" from WebFrameScheduler and other classes having
the same name for consistency with other Web classes.

This patch touches a lot of files, but the changes in those files are
basically simple renames. No behavior change is expected.

LocalFrame::FrameScheduler() was renamed to GetFrameScheduler() because
of the name conflict.

Bug:  825094 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1c90ac0020c57382bbcb636ba58b9a0d6f1c849b
Reviewed-on: https://chromium-review.googlesource.com/977246
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545758}
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/paint/PaintTiming.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/scheduler/FrameSchedulerTest.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/script/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/script/PendingScript.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/script/ScriptLoader.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/FrameScheduler.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/WebThread.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_origin_type.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_origin_type.h
[rename] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_scheduler_impl.cc
[rename] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_scheduler_impl.h
[rename] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_status.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/frame_status.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[rename] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/test/fake_frame_scheduler.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/Source/platform/scheduler/test/fake_page_scheduler.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/public/platform/WebThread.h
[modify] https://crrev.com/0144aa846ddecbedcc5123cb3772623527d37c8b/third_party/WebKit/public/web/WebLocalFrame.h

Comment 2 by yutak@chromium.org, Mar 27 2018

Status: Fixed (was: Started)

Sign in to add a comment