New issue
Advanced search Search tips

Issue 825081 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 723233
issue 787866



Sign in to add a comment

Cleanup UMAs for Loading Dispatcher

Project Member Reported by ksakamoto@chromium.org, Mar 23 2018

Issue description

We added a lot of metrics to measure the impact of Loading Dispatcher v0. We've collected enough data to conclude the experiment, so let's remove UMAs that are no longer needed.

 
Cc: horo@chromium.org
+horo@

We'd like to remove Memory.Experimental.Renderer.*.PeakDuringLoad as these have performance overhead. But PWAFullCodeCache experiment ( Issue 768705 ) which recently started in stable channel may improve PeakDuringLoad, so we'll keep them for a while until we can see the impact.

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2304dfae66a8716045bdd5638fddf8ff8eb5002d

commit 2304dfae66a8716045bdd5638fddf8ff8eb5002d
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Mar 28 02:39:05 2018

Remove Net.ResourceDispatcherHost.PeakOutstandingRequests UMA

This is essentially a revert of http://crrev.com/2951643003.
This was a temporary UMA only to measure the impact of Loading
Dispatcher v0, and it wasn't work correctly when OOPIF is enabled.

Bug:  787866 ,825081
Change-Id: Icc4644d97e70a2c8a793737763a0b4ca1be55180
Reviewed-on: https://chromium-review.googlesource.com/977202
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546370}
[modify] https://crrev.com/2304dfae66a8716045bdd5638fddf8ff8eb5002d/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/2304dfae66a8716045bdd5638fddf8ff8eb5002d/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/2304dfae66a8716045bdd5638fddf8ff8eb5002d/tools/metrics/histograms/histograms.xml

Horo-san, can we remove the *.PeakDuringLoad UMAs now?

Comment 4 by horo@chromium.org, Apr 6 2018

Yes. please :)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664

commit ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Apr 06 06:41:48 2018

Remove Memory.Experimental.Renderer.*.PeakDuringLoad

These metrics were added to collect peak memory stats during page load.
These have been disabled on Windows due to performance regression, but
have non-negligible overhead on other platforms too.

We have collected enough data for our experiment, so let's remove them.

Bug: 825081
Change-Id: I2cedc5982538127074b6e2c271b4d51aef14ad4f
Reviewed-on: https://chromium-review.googlesource.com/961982
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548698}
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/content/public/common/content_features.cc
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/content/public/common/content_features.h
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/content/renderer/render_frame_impl.h
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/content/renderer/render_widget_browsertest.cc
[modify] https://crrev.com/ff1c7f14e210dfd970ba06df9fe2c8d3cdbc4664/tools/metrics/histograms/histograms.xml

Sign in to add a comment