New issue
Advanced search Search tips

Issue 825045 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in descriptor_number < number_of_descriptors() in objects-inl.h

Project Member Reported by ClusterFuzz, Mar 23 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5170330226917376

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  descriptor_number < number_of_descriptors() in objects-inl.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=48638:48639

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5170330226917376

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 23 2018

Labels: Test-Predator-Auto-Owner
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/594803c94671fa19db1420f2b43023b75264e101 ([turbofan] Inline Function#bind in more cases.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 2 by cthomp@chromium.org, Mar 23 2018

Labels: Security_Impact-Stable OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows
The suspected regression CL is from last October, so I'm marking this Impact-Stable.

The fuzzer triggered in linux_d8_dbg, so I'm also expanding to all Blink OSes.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 24 2018

Labels: M-65
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 24 2018

Labels: Pri-1

Comment 5 by mmoroz@chromium.org, Mar 30 2018

bmeurer@, please take a look when you get a chance, as this is a High severity issue affecting Stable branch.
Cc: jarin@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/aa3020565f44396bb772c3aa508700493956d4d8

commit aa3020565f44396bb772c3aa508700493956d4d8
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Tue Apr 03 07:30:47 2018

[turbofan] Properly test number of descriptors.

When peeking into descriptor arrays (for Function.prototype.bind
inlining), we need to check the number of descriptors rather than
the length of the DescriptorArray.

Bug:  chromium:825045 
Change-Id: I55dbe1544e5e4cb8e23d873961c71ed12294d89c
Reviewed-on: https://chromium-review.googlesource.com/991812
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52315}
[modify] https://crrev.com/aa3020565f44396bb772c3aa508700493956d4d8/src/compiler/js-call-reducer.cc
[add] https://crrev.com/aa3020565f44396bb772c3aa508700493956d4d8/test/mjsunit/regress/regress-crbug-825045.js

Status: Fixed (was: Started)
Labels: Merge-Request-66
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 3 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 3 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
This will land in Canary tonight, so let's confirm once it has landed first! 
Project Member

Comment 13 by ClusterFuzz, Apr 4 2018

ClusterFuzz has detected this issue as fixed in range 52314:52315.

Detailed report: https://clusterfuzz.com/testcase?key=5170330226917376

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  descriptor_number < number_of_descriptors() in objects-inl.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=48638:48639
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52314:52315

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5170330226917376

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Apr 4 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5170330226917376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
How does change in canary look?
friendly ping - can you please confirm how safe this merge is overall?

Comment 17 by cmasso@google.com, Apr 10 2018

This fix should be merged today if it should be in the Android stable build
Cc: awhalley@chromium.org
awhalley@, I guess we are not taking this high level security fix in M66
Apologies, should have set my OOO on monorail :-|

Change is good for 66 merge. Let's try and get it in anyway in case there's another chance to pick it up.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 12 2018

Labels: merge-merged-6.6
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/17d66a38c99538c7e16b1b821d0d9a15b18d2d61

commit 17d66a38c99538c7e16b1b821d0d9a15b18d2d61
Author: Benedikt Meurer <bmeurer@google.com>
Date: Thu Apr 12 07:19:24 2018

Merged: [turbofan] Properly test number of descriptors.

Revision: aa3020565f44396bb772c3aa508700493956d4d8

BUG= chromium:825045 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=jarin@chromium.org

Change-Id: I94c60d024db10da34ae0e87aefea8685a37fcc49
Reviewed-on: https://chromium-review.googlesource.com/1009622
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.6@{#47}
Cr-Branched-From: d500271571b92cb18dcd7b15885b51e8f437d640-refs/heads/6.6.346@{#1}
Cr-Branched-From: 265ef0b635f8761df7c89eb4e8ec9c1a6ebee184-refs/heads/master@{#51624}
[modify] https://crrev.com/17d66a38c99538c7e16b1b821d0d9a15b18d2d61/src/compiler/js-call-reducer.cc
[add] https://crrev.com/17d66a38c99538c7e16b1b821d0d9a15b18d2d61/test/mjsunit/regress/regress-crbug-825045.js

Labels: -Merge-Review-66
Labels: Release-0-M66
Project Member

Comment 23 by sheriffbot@chromium.org, Jul 10

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment