New issue
Advanced search Search tips

Issue 825041 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update EncryptionScheme

Project Member Reported by jrumm...@chromium.org, Mar 22 2018

Issue description

Currently EncryptionScheme has CipherMode and EncryptionPattern fields. They should be separated out so that EncryptionPattern can be optional. This also allows Audio/VideoDecoderConfig to note that the pattern (if specified) is the default for the file.

And CipherMode should be replaced by EncyptionMode from DecryptConfig (which should land shortly) so that it references the actual scheme used by the media, and not the cipher mode directly. The cipher can be derived from EncryptionMode. This will allow future encryption schemes to be supported.
 

Comment 1 by xhw...@chromium.org, Apr 19 2018

Labels: -Pri-3 M-69 Pri-2
Assign milestone to make sure this is not forgotten.

Comment 2 by xhw...@chromium.org, Jun 12 2018

Cc: yucliu@chromium.org
I think we should merge EncryptionScheme with EncryptionMode + EncryptionPattern:

1. In AudioDecoderConfig and VideoDecoderConfig, pass EncryptionMode instead of EncryptionScheme. Note that this means we are not passing the pattern in *DecoderConfig. The pattern will be passed in DecoderBuffer at decryption/decoding time.

2. Remove EncryptionScheme.

3. Rename EncryptionMode to EncryptionScheme and move it to encrytion_scheme.*

yucliu: WDYT? Will this work for ChromeCast, especially step 1? Also, we are busy and since this is touching an existing cast path the most, would it be possible for you to pick up this work?
Labels: -Pri-2 -M-69 Pri-3
Lowering priority as this is code cleanup.

Sign in to add a comment