Rendering issue with HTML elements over video element
Reported by
dv-web-p...@amazon.com,
Mar 22 2018
|
|||||||||||||||||
Issue descriptionChrome Version : 67.0.3378.0 (Official Build) canary (64-bit) URLs (if applicable) : https://www.amazon.com/dp/B01J94B90W Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: OK Firefox: OK Edge: OK What steps will reproduce the problem? (1) Scroll down so episode 3 or so is at the top of the window. (2) Play an episode. What is the expected result? UI is rendered over the video element. What happens instead? Video element is rendered over the UI elements, with the UI elements sometimes flashing over the video. Please provide any additional information below. Attach a screenshot if possible. Seeing this issue in Chrome Beta as well.
,
Mar 23 2018
Can you confirm there are no flags enabled when this happens?
,
Mar 23 2018
Issue 825156 has been merged into this issue.
,
Mar 23 2018
We haven't enabled any flags. Only ones that are enabled are the ones that come enabled by default.
,
Mar 23 2018
Do you have any examples that don't require amazon prime to use? Could you try running with chrome://flags/#composited-layer-borders turned on and take a screenshot of the result? My intuition is that this is something wrong around the PaintLayerCompositor level.
,
Mar 23 2018
,
Mar 23 2018
Screenshot attached. The steps in the issue that was merged with this one should work without a Prime account. 1) Go to amazon.com/video 2) Scroll down a bit 3) Hover over a movie 4) Click "Watch Trailer"
,
Mar 23 2018
brajkumar: Can TE run a bisect on this? I can confirm I see the UI under the video on Mac canary 67.0.3372.0 with the instructions in #7.
,
Mar 24 2018
Able to reproduce the issue on chrome version #67.0.3378.0 using Windows 10, mac 10.12.6 and Ubuntu 14.04, as the issue was in branch builds, hence providing manual change log from omahaproxy Bisect Information: ===================== Good build: 66.0.3359.43 Bad Build : 66.0.3359.45 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/66.0.3359.43..66.0.3359.45?pretty=fuller&n=10000 Commit: https://chromium.googlesource.com/chromium/src/+/cee8973f56386ace74fa77b87e81224c04ca7b26 Change-Id: I48a92d0614d97c745fe66b1265dce0613514ffc4 Reviewed-on: https://chromium-review.googlesource.com/961643 @Tien-Ren Chen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Mar 25 2018
Issue 825198 has been merged into this issue.
,
Mar 30 2018
trchen@, can you please look into it?
,
Mar 30 2018
,
Apr 2 2018
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks!
,
Apr 9 2018
Friendly ping to get an update on this issue as it is marked as stable blocker & M66 Stable cut is on April 12th. Thanks..!
,
Apr 9 2018
I suspect this is the same root cause as crbug.com/825543 However I couldn't test this on local builds due to video DRM. The latest dev release hasn't included the fix for 825543, and the bug is still present. If we could verify this no longer repro on the next dev release, we can confirm it is a dupe of 825543.
,
Apr 9 2018
Reminder: Please note that M66 Stable is only 7 days away. This bug has been marked as ReleaseBlock Stable for M66. So please take a look and appropriately address this bug.
,
Apr 12 2018
Just to update: Seeing below 2 issues on chrome Beta-66.0.3359.81, Dev-67.0.3393.4 & Canary-67.0.3394.0. No issue observed on stable-65.0.3325.181. 1. Observed Single line when we pause any video in espn.in with and without flash update 2. Volume bar is hidden while playing any video in amazon.com before maximize (with and without flash update) Regression Range: --------------- Good build: 66.0.3359.43 Bad Build : 66.0.3359.45 Note: ----- As per C#15,seems #825543-issue got fixed & working as intended on latest chrome beta RC-66.0.3359.106. Please find the attached screencast for reference. trchen@, Please take a look into these issues & update the thread accordingly as it is marked as M66 RBS. Thanks..!
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c281fdaea591a387c1cd185245c269b0dd6f20d commit 4c281fdaea591a387c1cd185245c269b0dd6f20d Author: Tien-Ren Chen <trchen@chromium.org> Date: Fri Apr 13 19:46:51 2018 [Blink] Correct clip rect computation with non-manually-scrollable root PaintLayerClipper returns a counter-scrolled rect when kIgnoreOverflowClipAndScroll is specified. Before this CL the counter-scroll was not applied if the scroller is not manually scrollable, e.g. overflow:hidden with a scroll offset. BUG= 825033 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I05ad28a584911143e45204c751f679592ab03e19 Reviewed-on: https://chromium-review.googlesource.com/1011214 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550725} [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute-expected.html [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute.html [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed-expected.html [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed.html [modify] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc [modify] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc [modify] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
,
Apr 13 2018
,
Apr 13 2018
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 14 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 15 2018
Pls merge your change to M67 branch 3396 by 1:00 PM PT Monday (04/16/18) so we can pick it up for next M67 dev release. Thank you.
,
Apr 16 2018
Thanks for the fix. Has this been verified in canary? Stable release is tomorrow. Confirmed with trchen@ that this is a safe fix and regression is pretty bad; however, this needs to be tested in canary first.
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/975d2ed4ca806cead1f20317bf67f54404c6157e commit 975d2ed4ca806cead1f20317bf67f54404c6157e Author: Tien-Ren Chen <trchen@chromium.org> Date: Mon Apr 16 19:28:13 2018 [Blink] Correct clip rect computation with non-manually-scrollable root PaintLayerClipper returns a counter-scrolled rect when kIgnoreOverflowClipAndScroll is specified. Before this CL the counter-scroll was not applied if the scroller is not manually scrollable, e.g. overflow:hidden with a scroll offset. BUG= 825033 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I05ad28a584911143e45204c751f679592ab03e19 Reviewed-on: https://chromium-review.googlesource.com/1011214 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550725}(cherry picked from commit 4c281fdaea591a387c1cd185245c269b0dd6f20d) Reviewed-on: https://chromium-review.googlesource.com/1012786 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#22} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute-expected.html [add] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute.html [add] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed-expected.html [add] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed.html [modify] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc [modify] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc [modify] https://crrev.com/975d2ed4ca806cead1f20317bf67f54404c6157e/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
,
Apr 16 2018
Since this hasn't baked in canary, I'm not comfortable taking this change in M66 for tomorrow's release. Once the fix has baked, let's consider it for a future M66 respin (if any).
,
Apr 16 2018
I also tried replicating this issue on M66 Beta on Mac, and it seems to be working fine?
,
Apr 16 2018
We are still seeing this issue on M66 beta for Mac.
,
Apr 16 2018
Approving this merge for M66. Branch:3359 We will verify this in canary tonight and on the stable candidate.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61bd0afa226ea46151266071ec39a82d82c9ce5b commit 61bd0afa226ea46151266071ec39a82d82c9ce5b Author: Philip Rogers <pdr@chromium.org> Date: Tue Apr 17 00:06:47 2018 [Blink] Correct clip rect computation with non-manually-scrollable root This is a manual merge of: 4c281fdaea591a387c1cd185245c269b0dd6f20d PaintLayerClipper returns a counter-scrolled rect when kIgnoreOverflowClipAndScroll is specified. Before this CL the counter-scroll was not applied if the scroller is not manually scrollable, e.g. overflow:hidden with a scroll offset. BUG= 825033 (cherry picked from commit 4c281fdaea591a387c1cd185245c269b0dd6f20d) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I05ad28a584911143e45204c751f679592ab03e19 Reviewed-on: https://chromium-review.googlesource.com/1011214 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550725} Reviewed-on: https://chromium-review.googlesource.com/1014648 Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#722} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [add] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute-expected.html [add] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute.html [add] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed-expected.html [add] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed.html [modify] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/61bd0afa226ea46151266071ec39a82d82c9ce5b/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdater.cpp
,
Apr 17 2018
Able to reproduce the issue on chrome reported version 67.0.3378.0 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #66.0.3359.117 as per the comment#0 & 7 Attaching screen cast for reference. Observed "UI is rendered over the video element" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Apr 17 2018
Adding to the comment#30, fix is working fine on latest chrome canary 68.0.3398.0 on Mac 10.12.6, Windows-10 & Ubuntu 14.04, hence adding verified label. Thanks!
,
Apr 17 2018
Woohoo, fixed.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c281fdaea591a387c1cd185245c269b0dd6f20d commit 4c281fdaea591a387c1cd185245c269b0dd6f20d Author: Tien-Ren Chen <trchen@chromium.org> Date: Fri Apr 13 19:46:51 2018 [Blink] Correct clip rect computation with non-manually-scrollable root PaintLayerClipper returns a counter-scrolled rect when kIgnoreOverflowClipAndScroll is specified. Before this CL the counter-scroll was not applied if the scroller is not manually scrollable, e.g. overflow:hidden with a scroll offset. BUG= 825033 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I05ad28a584911143e45204c751f679592ab03e19 Reviewed-on: https://chromium-review.googlesource.com/1011214 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550725} [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute-expected.html [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-absolute.html [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed-expected.html [add] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/WebKit/LayoutTests/compositing/overflow/overlap-testing-rect-with-scrolled-non-scrollable-root-layer-fixed.html [modify] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc [modify] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc [modify] https://crrev.com/4c281fdaea591a387c1cd185245c269b0dd6f20d/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
,
Apr 17 2018
Is any merge needed for M67?
,
Apr 17 2018
dv-web-players@amazon.com - can you confirm on canary?
,
Apr 17 2018
Re #34: I already done the merge for M67, see comment #24. All new releases on any branch should have this bug fixed. If not, let me know! |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by xhw...@chromium.org
, Mar 22 2018Components: Internals>Compositing Internals>Media
Labels: -Pri-3 ReleaseBlock-Stable M-66 OS-Mac OS-Windows Pri-1
Status: Available (was: Unconfirmed)