New issue
Advanced search Search tips

Issue 825027 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Apr 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] App stuck when host list fetching request fails

Project Member Reported by yuweih@chromium.org, Mar 22 2018 
App Version: 67.0.3378.0
OS Version: 11.2

If a request fails when fetching host list (e.g. 503 error), then the app will get stuck in the empty view. It's currently not showing the setup instruction or an error dialog. We should make it show an error dialog.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e12a8df8568268e56ddc4fc65c44a453980fe1c8

commit e12a8df8568268e56ddc4fc65c44a453980fe1c8
Author: Yuwei Huang <yuweih@chromium.org>
Date: Sat Apr 07 01:42:21 2018

[CRD iOS] Fix host fetching failure silently dropped and refactor HostListService

* Fix an issue of failed host fetching request being silently dropped.
* Move host list code inside RemotingService into a HostListService class,
  as a C++ class.
* Make HostListFetcher use OnceCallback, as HostListService is required to
  use new base::Bind(Once|Repeating) style.

Bug:  825027 
Change-Id: I99f02c403dda958b4b7f6384bd1f240d35bf258e
Reviewed-on: https://chromium-review.googlesource.com/977238
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549010}
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/BUILD.gn
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/DEPS
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/app/remoting_view_controller.mm
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/domain/host_info.h
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/domain/host_info.mm
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/BUILD.gn
[add] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/fake_host_list_fetcher.cc
[add] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/fake_host_list_fetcher.h
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/host_list_fetcher.cc
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/host_list_fetcher.h
[add] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/host_list_service.h
[add] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/host_list_service.mm
[add] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/host_list_service_unittest.mm
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/remoting_service.h
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/ios/facade/remoting_service.mm
[modify] https://crrev.com/e12a8df8568268e56ddc4fc65c44a453980fe1c8/remoting/resources/remoting_strings.grd

Comment 2 by yuweih@chromium.org, Apr 10 2018

Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Jul 19

Status: Verified (was: Fixed)
Verified Fixed in 67.0.3396.22
►

Sign in to add a comment