New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825002 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.9% regression in system_health.memory_mobile at 515123:515167

Project Member Reported by chiniforooshan@chromium.org, Mar 22 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 22 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=825002

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=eb32e0357269878e399bd21171274c3e0f8be51c410d5e0c081ea92e96b54c59


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 23 2018

Cc: vasi...@chromium.org kolos@chromium.org charliea@chromium.org jgruber@chromium.org nedngu...@google.com xunji...@chromium.org
Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12e868fd440000

[Password Manager] Show confirmation bubble as manual fallback for generated cases by kolos@chromium.org
https://chromium.googlesource.com/chromium/src/+/eb2186f3682000349de07278cc013da765ba364c

[snapshot] Flip --lazy-handler-deserialization by jgruber@chromium.org
https://chromium.googlesource.com/v8/v8/+/9664d017f7e219878d4b1a6c25be6c6f9b1b91bd

Reland "Make TracingControllerBackend.StopTracing() return nonfatal exceptions" by charliea@chromium.org
https://chromium.googlesource.com/catapult/+/013ddeb8a2fd8d246de026c043d915cf895c41c0

Update wprgo binaries to latest version by nednguyen@google.com
https://chromium.googlesource.com/catapult/+/564e33d345ee080be36ad0e6b6107afbcd09df4d

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Ned, is it expected that the wprgo update would cause a memory increase? If so, can you mark WontFix?
It's expected to contribute some of the memory increase, but I am not sure how much. What do we do about the other commits identified by pinpoint?
Owner: ----
Status: Available (was: Assigned)
I highly suspect that this is mostly caused by wprgo patch because I don't see memory regression on the desktop benchmark
Status: WontFix (was: Available)
WontFix, since the wprgo change had expected memory impact. If you look at the pinpoint chart, the other CLs caused very small memory improvements, and pinpoint detects all changes.

Sign in to add a comment