New issue
Advanced search Search tips

Issue 824997 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073
issue 721398



Sign in to add a comment

Need an API to clear reporting information in network service

Project Member Reported by mmenke@chromium.org, Mar 22 2018

Issue description

See ClearReportingCacheOnIOThread (https://cs.chromium.org/search/?q=ClearReportingCacheOnIOThread&sq=package:chromium&type=cs).  We need a Mojo API to wrap the call, and we need to update the BrowsingDataRemover to use it.  We should also move it from ChromeBrowsingDataRemover to content::BrowsingDataRemover, since this will be part of the network service's public API.
 

Comment 1 by mmenke@chromium.org, Mar 22 2018

Blocking: -715640 598073

Comment 2 by mmenke@chromium.org, Mar 22 2018

May make sense to handle ClearNetworkErrorLoggingOnIOThread at the same time, which needs basically the same changes.
Blocking: 721398
Owner: ericorth@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b812a44188b64df26743477c26f38eb2cf91182f

commit b812a44188b64df26743477c26f38eb2cf91182f
Author: Eric Orth <ericorth@chromium.org>
Date: Fri May 04 20:26:48 2018

Add network service methods to clear reporting cache.

Created as two separate methods, one for reports and one for clients,
to avoid polluting the interface with a data_type_mask as is used
internally. Also, to avoid dealing with confusing difference between
always-true filter and null filter when they should logically be
equivalent, cleaned up ReportingCache to explicitly have two separate
clear data methods, one that clears everything without filter and one
that always assumes it has a valid filter.

Bug:  824997 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If8fc3698eb61efbdee566dbd55e649723ff1e3d8
Reviewed-on: https://chromium-review.googlesource.com/1038524
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556177}
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/BUILD.gn
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/network_error_logging/network_error_logging_service_unittest.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/reporting/reporting_browsing_data_remover.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/reporting/reporting_browsing_data_remover.h
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/reporting/reporting_browsing_data_remover_unittest.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/reporting/reporting_service.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/reporting/reporting_service.h
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/services/network/network_context.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/services/network/network_context.h
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/services/network/network_context_unittest.cc
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/b812a44188b64df26743477c26f38eb2cf91182f/services/network/test/test_network_context.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26a408fd2335deedd73dbc32e14e92fb5545393b

commit 26a408fd2335deedd73dbc32e14e92fb5545393b
Author: Eric Orth <ericorth@chromium.org>
Date: Wed May 09 15:43:40 2018

Add network service method to clear NetworkErrorLogging data.

Minor cleanup in NetworkErrorLoggingService by making non-filtered
cleanup an explicit separate method.

Bug:  824997 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iaa7b9fa25a7463a7294d93759dca0b0ee06187a0
Reviewed-on: https://chromium-review.googlesource.com/1044359
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557195}
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/net/network_error_logging/network_error_logging_service.h
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/net/network_error_logging/network_error_logging_service_unittest.cc
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/services/network/network_context.cc
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/services/network/network_context.h
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/services/network/network_context_unittest.cc
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/26a408fd2335deedd73dbc32e14e92fb5545393b/services/network/test/test_network_context.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ce1bf966d76500a74a472d542ba5a400b0bf9d0

commit 6ce1bf966d76500a74a472d542ba5a400b0bf9d0
Author: Eric Orth <ericorth@chromium.org>
Date: Wed May 16 17:48:15 2018

Servicify browser data calls to clear reporting information.

Also servicified ClearNetworkErrorLogging as it's extremely similar
logic.

Moved the clearing on DATA_TYPE_COOKIES to BrowsingDataRemoverImpl as it
is not chrome-specific, and left the clearing on DATA_TYPE_HISTORY in
ChromeBrowsingDataRemoverDelegate. Especially good cleanup for Reporting
data as the two cases were split into two independent Clear... methods
in NetworkContext.

Bug:  824997 
Change-Id: Ie13ef2277d9040f73e87b77be49ba47305462aab
Reviewed-on: https://chromium-review.googlesource.com/1045206
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559172}
[modify] https://crrev.com/6ce1bf966d76500a74a472d542ba5a400b0bf9d0/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/6ce1bf966d76500a74a472d542ba5a400b0bf9d0/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/6ce1bf966d76500a74a472d542ba5a400b0bf9d0/content/browser/browsing_data/browsing_data_remover_impl.cc
[modify] https://crrev.com/6ce1bf966d76500a74a472d542ba5a400b0bf9d0/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment