This bug is filed off mmenke@'s list of starter bugs.

If anyone has free cycle, this one should be fairly straightforward.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0f248cdf03e95615736e5dbb706c9612a4c5b06

commit b0f248cdf03e95615736e5dbb706c9612a4c5b06
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Tue Jul 24 19:44:16 2018

Migrate NetBenchmarking from URLRequestContext to NetworkContext.

This will allow NetBenchmarking to be used with the network service
enabled. This also adds a NetworkContext::CloseAllConnections method.

Bug:  824974 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I566124d13e6607d579583202f030425ec2f3c598
Reviewed-on: https://chromium-review.googlesource.com/1135715
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577642}
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/chrome/browser/net_benchmarking.cc
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/chrome/browser/net_benchmarking.h
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/chrome/common/net_benchmarking.mojom
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/chrome/renderer/net_benchmarking_extension.cc
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/services/network/network_context.cc
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/services/network/network_context.h
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/services/network/network_context_unittest.cc
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/b0f248cdf03e95615736e5dbb706c9612a4c5b06/services/network/test/test_network_context.h

The only remaining reference to HttpNetworkSession::CloseAllConnections is in net internals (https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc?l=925&rcl=b23eba1f03652108c7724d92e56a2abb84cb0d2c).

I believe mmenke@ said that net_internals will be going away and doesn't need to be migrated. Matt, is that correct or am I misremembering?

[+eroman, +lassey]:  You're remembering correctly, but I think eroman and lassey have rather different opinions on what should become of net-internals.

Support for net-internals with Network Service isn't required for canary, so seems this bug can be closed, or at least have the Canary label removed.

As for whether we want to maintain the capability to close all connections from net-internals post Canary, I would say no. However I'll need to follow-up with an updated design doc for the end state of net-internals that accounts for network service.

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

hey eric, following up on Comment #11. 

Putting it in your queue for the design doc. If there is no work for launching to stable, then perhaps we don't need to track it anymore?

Chris has an inprogress CL that solves this (https://chromium-review.googlesource.com/c/chromium/src/+/1228235)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311

commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311
Author: Chris Mumford <cmumford@google.com>
Date: Fri Oct 26 17:37:02 2018

Switch chrome://net-internals to the network service.

This change switches the implementation of the net-internals
page from direct calls to //net to the network service.

Bug:  876110 , 824974 , 755600 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781
Reviewed-on: https://chromium-review.googlesource.com/c/1228235
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603135}
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/components/password_manager/core/browser/http_credentials_cleaner_unittest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/expect_ct_reporter.h
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context.h
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context_unittest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/test/test_network_context.h

things look good. request merge for M71.

This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M71 branch 3578 based on comment #24. Please merge ASAP. Thank you.

There were merge conflicts when cherry-picking into M71. Manually resolved and tested locally, but getting one reviewer to also take a look: https://chromium-review.googlesource.com/c/chromium/src/+/1316652

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ce5a5595246180b8e9c99eaceadcf5518eaa41a6

Commit: ce5a5595246180b8e9c99eaceadcf5518eaa41a6
Author: cmumford@google.com
Commiter: cmumford@chromium.org
Date: 2018-11-04 14:53:39 +0000 UTC

Switch chrome://net-internals to the network service.

Merge to release branch.

This change switches the implementation of the net-internals
page from direct calls to //net to the network service.

TBRing mmenke@ for review of network service_context changes.

TBR=mmenke@chromium.org

(cherry picked from commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311)

Bug:  876110 , 824974 , 755600 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781
Reviewed-on: https://chromium-review.googlesource.com/c/1228235
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603135}
Reviewed-on: https://chromium-review.googlesource.com/c/1316652
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#488}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce5a5595246180b8e9c99eaceadcf5518eaa41a6

commit ce5a5595246180b8e9c99eaceadcf5518eaa41a6
Author: Chris Mumford <cmumford@google.com>
Date: Sun Nov 04 14:53:39 2018

Switch chrome://net-internals to the network service.

Merge to release branch.

This change switches the implementation of the net-internals
page from direct calls to //net to the network service.

TBRing mmenke@ for review of network service_context changes.

TBR=mmenke@chromium.org

(cherry picked from commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311)

Bug:  876110 , 824974 , 755600 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781
Reviewed-on: https://chromium-review.googlesource.com/c/1228235
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603135}
Reviewed-on: https://chromium-review.googlesource.com/c/1316652
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#488}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/components/password_manager/core/browser/http_credentials_cleaner_unittest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/expect_ct_reporter.h
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context.h
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context_unittest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/test/test_network_context.h