Issue metadata
Sign in to add a comment
|
Need an API to clear ChannelIDStore in NetworkService |
||||||||||||||||||||||||
Issue descriptioncontent/browser/browsing_data/browsing_data_remover_impl.cc needs the ability to clear ChannelIDStore data. Filing a bug to add such API in NetworkService. An example CL can be found in https://chromium-review.googlesource.com/c/chromium/src/+/719736, which added an API to clear HSTS data and HttpServerProperties.
,
Mar 22 2018
,
Apr 12 2018
+nharper@: Nick, what's the deprecation schedule of ChannelID? We are considering migrating this functionality (clearing ChannelIDStore) to NetworkService. Let us know if this is no longer needed. +ericorth@ who started looking into this.
,
Apr 12 2018
Right now, the plan is to deprecate Channel ID in M68 (off-by-default) and hopefully completely remove in M69. However, the ChannelIDStore is also used by Token Binding. (Once the removal of Channel ID is done, I plan to rename the classes to have Token Binding in the name instead of Channel ID.)
,
Apr 18 2018
,
Apr 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f commit 1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f Author: Eric Orth <ericorth@chromium.org> Date: Sat Apr 21 00:29:46 2018 Clear ChannelIDStore using the network service. Add a new method with filter (by generalizing the ClearCacheUrlFilter) and time range support to NetworkContext. Use it from BrowsingDataRemoverImpl. Also changed some of the Closure parameters in ChannelIDStore to OnceClosure to more cleanly support calling with the mojo callbacks. Bug: 824970 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9a8bb37ef80ccda1d048c4c090ebc61855066960 Reviewed-on: https://chromium-review.googlesource.com/1013303 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#552530} [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/components/mirroring/service/fake_network_service.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/content/browser/browsing_data/browsing_data_filter_builder_impl.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/content/browser/browsing_data/browsing_data_filter_builder_impl.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/content/browser/browsing_data/browsing_data_filter_builder_impl_unittest.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/content/browser/browsing_data/browsing_data_remover_impl.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/content/public/browser/browsing_data_filter_builder.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/net/socket/ssl_client_socket_unittest.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/net/ssl/channel_id_store.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/net/ssl/default_channel_id_store.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/net/ssl/default_channel_id_store.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/http_cache_data_remover.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/http_cache_data_remover.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/http_cache_data_remover_unittest.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/network_context.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/network_context.h [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/network_context_unittest.cc [modify] https://crrev.com/1d5637afbb6fa46221fb1f1c3f83dd9b9ede144f/services/network/public/mojom/network_service.mojom
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/501957ddc606ade792810971bb86fc2cbec29fd3 commit 501957ddc606ade792810971bb86fc2cbec29fd3 Author: Eric Orth <ericorth@chromium.org> Date: Wed Apr 25 23:02:52 2018 Move SSL config change notification after channel ID clearing to network service. Bug: 824970 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5adf0dc043bb6e3683f013036f1c42eb7364f016 Reviewed-on: https://chromium-review.googlesource.com/1017322 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#553803} [modify] https://crrev.com/501957ddc606ade792810971bb86fc2cbec29fd3/content/browser/browsing_data/browsing_data_remover_impl.cc [modify] https://crrev.com/501957ddc606ade792810971bb86fc2cbec29fd3/services/network/network_context.cc [modify] https://crrev.com/501957ddc606ade792810971bb86fc2cbec29fd3/services/network/network_context_unittest.cc
,
Apr 26 2018
Eric, can this bug be closed? I don't see anything else is needed here.
,
Apr 27 2018
Yup. Work is done. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Mar 22 2018