Overflow Menu - Close incognito tags menu item appear without incognito tabs opened. |
|||
Issue descriptionChrome Version: 67.0.3378.0 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Got to http://www.google.com (2) Enter VR Browsing (3) Click on Overflow menu (4) Click Refresh button (5) Click on Overflow menu again What is the expected result? Same Overflow menu should appear since we are not in Incognito mode What happens instead? A new menu item "Close incognito tags" appears. This happens on Refresh or Navigation to new page. Only the initial dialog is correct. NOTE - Also if the user closes a current Incognito mode being returned to normal Chrome the "Close incognito tags" item should be remove from the menu.
,
Mar 23 2018
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d92fe674cc06288bfd844d92f269d237e2ad03e commit 5d92fe674cc06288bfd844d92f269d237e2ad03e Author: Christopher Grant <cjgrant@chromium.org> Date: Sat Mar 24 00:29:38 2018 VR: Don't manipulate incognito tab state for regular tabs. BUG= 824969 R=mthiesse Change-Id: Ifeb8f82e41ade9bdb10c7649cb7d2a4f1e06851c Reviewed-on: https://chromium-review.googlesource.com/978659 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#545647} [modify] https://crrev.com/5d92fe674cc06288bfd844d92f269d237e2ad03e/chrome/browser/android/vr/vr_shell.cc
,
Mar 24 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cjgrant@chromium.org
, Mar 22 2018Status: Assigned (was: Untriaged)