New issue
Advanced search Search tips

Issue 824967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Add the ability to clear HttpAuthCache in NetworkService

Project Member Reported by xunji...@chromium.org, Mar 22 2018

Issue description

We need to add an API in NetworkService to clear HttpAuthCache data (via HttpAuthCache::ClearEntriesAddedWithin), and convert content/browser/browsing_data/browsing_data_remover_impl.cc to using it.


An example CL can be found in https://chromium-review.googlesource.com/c/chromium/src/+/719736, which added an API to clear HSTS data and HttpServerProperties.


 
This bug is filed off mmenke@'s list of starter bugs.

If anyone has free cycle, this one should be fairly straightforward.

Comment 2 by mmenke@chromium.org, Mar 22 2018

Blocking: 715640

Comment 3 by mmenke@chromium.org, Mar 22 2018

Blocking: -715640 598073
Oops.
Owner: ericorth@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47be7b771e2c4bf655207896a611270a6032f039

commit 47be7b771e2c4bf655207896a611270a6032f039
Author: Eric Orth <ericorth@chromium.org>
Date: Tue May 01 19:58:42 2018

Clear HTTP auth cache in BrowsingDataRemover using network service.

To avoid issues dealing between Time (as we have for removal window in
BrowsingDataRemover) and TimeTick (as we have for cache timestamps), as
well as cross-process complexities from TimeTick, added a new wall
clock creation timestamp in the cache and new methods for absolute wall
time clearing.  Wall clock based clearing (eg those coming from
BrowsingDataRemover) can use the new timestamp and other stuff that
makes more sense using TimeTick (eg the histogram stuff in the cache
class) can keep using the old timestamp.

Bug:  824967 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I87bfce922ba28525ad20999fdfc6b7e2857451c0
Reviewed-on: https://chromium-review.googlesource.com/1026232
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555158}
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/content/browser/browsing_data/browsing_data_remover_impl.cc
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/content/browser/browsing_data/browsing_data_remover_impl_browsertest.cc
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/net/http/http_auth_cache.cc
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/net/http/http_auth_cache.h
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/net/http/http_auth_cache_unittest.cc
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/services/network/network_context.cc
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/services/network/network_context.h
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/services/network/network_context_unittest.cc
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/47be7b771e2c4bf655207896a611270a6032f039/services/network/test/test_network_context.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec9caca751eb6c7943e1263c4d5b3c30bfb59b3a

commit ec9caca751eb6c7943e1263c4d5b3c30bfb59b3a
Author: Eric Orth <ericorth@chromium.org>
Date: Thu May 03 21:30:50 2018

Servicify http auth cache removal in ChromeBrowsingDataRemoverDelegate.

Bug:  824967 
Change-Id: I4eb57d85bb057061bf12848f39127a6542ebe886
Reviewed-on: https://chromium-review.googlesource.com/1037523
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555881}
[modify] https://crrev.com/ec9caca751eb6c7943e1263c4d5b3c30bfb59b3a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/ec9caca751eb6c7943e1263c4d5b3c30bfb59b3a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

Status: Fixed (was: Started)

Sign in to add a comment