BrowserTest.OtherRedirectsDontForkProcess fails with --site-per-process |
||
Issue descriptionBrowserTest.OtherRedirectsDontForkProcess failure in --site-per-process mode is a long-known issue - I am opening a more granular mode in preparation for moving test exceptions out of testing/buildbot/filters/site-per-process.browser_tests.filter into source code of individual tests (which in turn is needed for flipping --site-per-process to be the default for //chrome on ToT).
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1c039e493c3a2bbde717f71273a9fba792ab498 commit c1c039e493c3a2bbde717f71273a9fba792ab498 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Mar 27 16:26:47 2018 Inline site-per-process expectations for //chrome-layer tests. We plan to make --site-per-process mode the default mode on ToT for //chrome layer. To make this switch slightly easier, this CL inlines the test expectations from //testing/buildbot/filters into the source code of the tests - this should avoid having to keep passing the filter files to the default test steps after making the switch. Bug: 671734, 824962, 824966 Change-Id: I4ce397f5a7be18cc184f081058bf57f2e7c6239f Reviewed-on: https://chromium-review.googlesource.com/976643 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#546128} [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/chrome/test/BUILD.gn [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/PRESUBMIT.py [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/chromium.linux.json [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/filters/BUILD.gn [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/filters/README.md [delete] https://crrev.com/36cb2980b99b9302adf4e681511431b17f335693/testing/buildbot/filters/site-per-process.browser_tests.filter [delete] https://crrev.com/36cb2980b99b9302adf4e681511431b17f335693/testing/buildbot/filters/site-per-process.interactive_ui_tests.filter [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/c1c039e493c3a2bbde717f71273a9fba792ab498/testing/buildbot/test_suites.pyl
,
Aug 3
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90615eb3f0c3293fc5a469f37caa87aa504c8906 commit 90615eb3f0c3293fc5a469f37caa87aa504c8906 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Aug 06 21:06:56 2018 Update site-per-process expectations for OtherRedirectsDontForkProcess. Verifications inside BrowserTest.OtherRedirectsDontForkProcess test were not applicable to site-per-process mode (e.g. they assumed that a cross-site pop-up, or a cross-site top-level navigation would always reuse the same process). This CL tweaks the test, so that it has different expectations with and without site-per-process mode. Bug: 824962 Change-Id: I1b5dfec0c45a8d578d64d4b259e28497d33b1ca9 Reviewed-on: https://chromium-review.googlesource.com/1162894 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580988} [modify] https://crrev.com/90615eb3f0c3293fc5a469f37caa87aa504c8906/chrome/browser/ui/browser_browsertest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, Mar 22 2018