New issue
Advanced search Search tips

Issue 824930 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

svg/animations/getCurrentTime-pause-unpause.html is flaky

Project Member Reported by wolenetz@chromium.org, Mar 22 2018

Issue description

The following layout test is flaky on Win, Linux, Mac

svg/animations/getCurrentTime-pause-unpause.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=svg%2Fanimations%2FgetCurrentTime-pause-unpause.html

Bots:
Win7 Tests (dbg)(1)
win_chromium_dbg_ng_

Example:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/10862

I'll mark this test as flaky soon.

Note: I was unable to find why the log summaries for the webkit_layout_test step like those in the example don't call out this test as being unexpectedly flaky -- I could find no related expectation of flakiness already in the code or recently changed in git history.
 
Bots+=
WebKit Linux Trusty (dbg)
WebKit Mac10.10
WebKit Mac10.11 (dbg)
Labels: OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecaec68d991fbde81d369d297da3b0a96d073b8a

commit ecaec68d991fbde81d369d297da3b0a96d073b8a
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Thu Mar 22 20:29:06 2018

svg/animations/getCurrentTime-pause-unpause.html is flaky

Mark flaky.

BUG= 824930 , 823003 
TBR=chrishtr@chromium.org
NO-TRY=True

Change-Id: Ib8c1e422d31210c8ae20742bd823000eabc3be3a
Reviewed-on: https://chromium-review.googlesource.com/976531
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545228}
[modify] https://crrev.com/ecaec68d991fbde81d369d297da3b0a96d073b8a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5284710d3b218dd27625e098a00e0210230f66a

commit c5284710d3b218dd27625e098a00e0210230f66a
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Mar 27 18:57:46 2018

Rewrite svg/animations/getCurrentTime-pause-unpause.html to avoid flakes

The test in it's current form imposed too strict requirements on the
time that had passed. We cannot guarantee a maximum elapsed time, only a
minimum (and barely that...) Rewrite the test to not impose any
restriction on the maximum elapsed time. Also convert it to use
testharness while at it. Also rewrite/convert the sibling test with
setCurrentTime.

Bug:  824930 
Change-Id: I79882b0189e44790e3096c8346c2a0bf47276dd8
Reviewed-on: https://chromium-review.googlesource.com/981145
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#546190}
[delete] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/LayoutTests/svg/animations/getCurrentTime-pause-unpause-expected.txt
[delete] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/LayoutTests/svg/animations/getCurrentTime-pause-unpause-setCurrentTime-expected.txt
[modify] https://crrev.com/c5284710d3b218dd27625e098a00e0210230f66a/third_party/WebKit/LayoutTests/svg/animations/getCurrentTime-pause-unpause-setCurrentTime.html
[modify] https://crrev.com/c5284710d3b218dd27625e098a00e0210230f66a/third_party/WebKit/LayoutTests/svg/animations/getCurrentTime-pause-unpause.html

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e89a90bf8698a7a15c9202e4e09449adcbd2fd

commit 84e89a90bf8698a7a15c9202e4e09449adcbd2fd
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Apr 03 11:51:18 2018

svg/animations/getCurrentTime-pause-unpause.html no longer flaky

TBR=schenney@chromium.org

Bug:  824930 
Change-Id: I123f2d2c7e95e5bbb0dd90abeab57246d312bc54
Reviewed-on: https://chromium-review.googlesource.com/992037
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#547674}
[modify] https://crrev.com/84e89a90bf8698a7a15c9202e4e09449adcbd2fd/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by f...@opera.com, Apr 3 2018

Status: Fixed (was: Available)

Comment 7 by f...@opera.com, Apr 3 2018

Owner: f...@opera.com

Sign in to add a comment