New issue
Advanced search Search tips

Issue 824928 link

Starred by 2 users
Status: Fixed
Owner:
kjlubick@chromium.org
Closed: Apr 2018
Cc:
bpastene@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

swarming task list filtering w/ buildername: + name: no longer works?

Project Member Reported by jbudorick@chromium.org, Mar 22 2018 
I frequently want to look at all of a given task on a builder; filtering w/ buildername:foo_builder & name:bar_test used to work for that. It no longer does?

Comment 1 by mar...@chromium.org, Mar 22 2018

Labels: -Pri-2 Pri-1
Indeed this is a regression on "buildername". Not sure why.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3

commit 9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Fri Mar 23 16:59:51 2018

Revert "Change to -tag suffix"

This reverts commit 24d9b1e53d0f7f2e47390860481fe1a58d8242c1.

Reason for revert: It's impossible to filter by some tags now.

As I'm doing unrelated tricky refactoring, it may be hard to go back
to older revisions and Kevin is OOO. This can be reapplied with fix
later.

Bug:785261,  824928 

Original change's description:
> Change to -tag suffix
> 
> Also de-duplicate dimensions and -tags
> 
> BUG:785261
> 
> Change-Id: I08e43801e5b89ed8ac8bd72b97e76e15c7801722
> Reviewed-on: https://chromium-review.googlesource.com/968707
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Commit-Queue: Kevin Lubick <kjlubick@chromium.org>

TBR=maruel@chromium.org,kjlubick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4e0b5e72148089b8aad6ab8c4f8c32be5bbf2935
Reviewed-on: https://chromium-review.googlesource.com/977864
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/tasklist/task-list.html
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939

commit 5ae95288441ee0d2b2ffcb0c67dded76f4ae5939
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Apr 04 12:13:39 2018

Reland 24d9b1e53d0f7f2e47390860481fe1a58d8242c1

Change to -tag suffix

Also de-duplicate dimensions and -tags


Bug:  785261 ,  824928 
Change-Id: Ief86435b127cc8e38add3f615648991d37223456
Reviewed-on: https://chromium-review.googlesource.com/993422
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/build/js/js.js
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/tasklist/task-list.html

Comment 4 by kjlubick@google.com, Apr 4 2018

Status: Fixed (was: Assigned)
Remedied with a revert, a revised re-land, and a release.

Revisit if I was remiss and a problem resurfaces.

Comment 5 by jbudorick@chromium.org, Apr 4 2018

Status: Assigned (was: Fixed)
While I appreciate the alliterative advice, I'm still seeing such situations :(

... on chromium-swarm, at least, and tag-name no longer seems to work, either

Comment 8 by maruel@google.com, Apr 6 2018

Status: Fixed (was: Assigned)
Fix deployed to prod.
►

Sign in to add a comment