Tapping on "Done" in incognito tab switcher should open last tab even if it's a non-incognito one |
||||||
Issue descriptionCanary from 3/22 What steps will reproduce the problem? (1) Make sure to have a few tabs open, both incongnito and non-incognito (2) Go to a non-incognito tab (3) Tap on tab switcher (4) Swipe left to see list of incognito tabs (5) Tap "Done" What is the expected result? Chrome should open the last tab that was open (in this case a non-incognito one). What happens instead? Chrome opens the last incognito tab that was open. Note: the same problem happens in reverse. If you start from an incognito tab and navigate to non-incognito tab switcher then hit "Done," it opens the latest non-incognito tab.
,
Mar 23 2018
,
Mar 23 2018
,
Mar 23 2018
CL is in-flight.
,
Mar 23 2018
,
Mar 23 2018
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf8681e12d1f7b38c976f5a6fa5675dfc249d27 commit 1bf8681e12d1f7b38c976f5a6fa5675dfc249d27 Author: edchin <edchin@chromium.org> Date: Fri Mar 23 14:59:12 2018 [ios] Fix faulty done button logic The Done button logic was faulty in two ways: 1) Enabling/disabling logic was flawed. 2) Tapping Done would show incognito when it should show the regular tab. (And vice-versa). Done button should only disable after the original page (incognito or regular tabs) where the user entered the tab grid is depleted of tabs. This CL fixes this by bookkeeping the |originalPage| that the user entered the tab grid. This CL also modifies the TabPresentationDelegate's |-showActiveTab| so that the intended page is specified in the method. This allows the TabGridViewController to pass the |originalPage| for Done button taps, and the |currentPage| for new tab button taps or tab cell taps. Bug: 824921 , 824912 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie81721a181f50b63a92722bf507986aa9596a4f5 Reviewed-on: https://chromium-review.googlesource.com/977561 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545449} [modify] https://crrev.com/1bf8681e12d1f7b38c976f5a6fa5675dfc249d27/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/1bf8681e12d1f7b38c976f5a6fa5675dfc249d27/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/1bf8681e12d1f7b38c976f5a6fa5675dfc249d27/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 27 2018
Issue verified Version: Chrome Canary 67.0.3382.0 Device: iPhone 6 Plus iOS: 11.2.6 Chrome opens the last tab that was open. https://drive.google.com/open?id=1W28EkZdORPF9FMPIdHg0sjQZ8HlenVao |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ghendel@google.com
, Mar 22 2018