Need to refactor the UI and API to not use args, kwargs. It is difficult to understand and debug.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/a9de6cd901ad9d2b885587a46d178a40800073d3 commit a9de6cd901ad9d2b885587a46d178a40800073d3 Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Apr 03 03:12:56 2018 [moblab] add params dialog for running mobmonitor action Added the dialog that will prompt users for params if the action requires them. Refactored the backend to do away with args, kwargs, and instead use a 'params' key value map. Updated unit tests for frontend and backend for all changes Snuck in the collect logs as it's a small change BUG= chromium:824884 , chromium:823965 TEST=ng test, e2e/run_e2e.sh, python mobmonitor_unittest.py, python manager_unittest.py Change-Id: Ic94da179ed9bcfedc194c01f88bd82bcec0e1118 Reviewed-on: https://chromium-review.googlesource.com/985252 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/mobmonitor_unittest.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/app.e2e-spec.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfile/manager.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.spec.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.module.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/mobmonitor.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/app.po.ts [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/disk_check.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/moblab_actions.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/proxy.conf.json [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.scss [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.spec.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.component.scss [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/shared/action-info.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/proxy-e2e.conf.json [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/actions/actions.component.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/README [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/shared/repair-service-info.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfile/manager_unittest.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.component.html [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/upstart_services_running_check.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/actions/actions.component.html [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.html
Comment 1 by haddowk@chromium.org
, Mar 22 2018