New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824884 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Refactor mobmonitor RunAction to not use args, kwargs

Project Member Reported by mattmallett@chromium.org, Mar 22 2018

Issue description

Need to refactor the UI and API to not use args, kwargs. It is difficult to understand and debug.

 
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/moblab/+/a9de6cd901ad9d2b885587a46d178a40800073d3

commit a9de6cd901ad9d2b885587a46d178a40800073d3
Author: Matt Mallett <mattmallett@chromium.org>
Date: Tue Apr 03 03:12:56 2018

[moblab] add params dialog for running mobmonitor action

Added the dialog that will prompt users for params if the
action requires them. Refactored the backend to do away
with args, kwargs, and instead use a 'params' key value
map.

Updated unit tests for frontend and backend for all changes

Snuck in the collect logs as it's a small change

BUG= chromium:824884 ,  chromium:823965 
TEST=ng test, e2e/run_e2e.sh,
python mobmonitor_unittest.py,
python manager_unittest.py

Change-Id: Ic94da179ed9bcfedc194c01f88bd82bcec0e1118
Reviewed-on: https://chromium-review.googlesource.com/985252
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/mobmonitor_unittest.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/app.e2e-spec.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfile/manager.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.spec.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.module.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/mobmonitor.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/app.po.ts
[add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/disk_check.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/moblab_actions.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/proxy.conf.json
[add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.scss
[add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.spec.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.component.scss
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/shared/action-info.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/proxy-e2e.conf.json
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/actions/actions.component.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/README
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/shared/repair-service-info.ts
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfile/manager_unittest.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.component.html
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/upstart_services_running_check.py
[modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/actions/actions.component.html
[add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.html

Status: Fixed (was: Started)

Sign in to add a comment