New issue
Advanced search Search tips

Issue 824839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove new_style from chromeos-dbus-bindings DBusSignature after migration

Project Member Reported by ejcaruso@chromium.org, Mar 22 2018

Issue description

This argument is temporary while we're migrating to new D-Bus bindings and we should remove it when all users of chromeos-dbus-bindings are on the new-style bindings.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/da87cd295cf0aa27ae20b8c65e81b94cc6600612

commit da87cd295cf0aa27ae20b8c65e81b94cc6600612
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Apr 06 21:44:05 2018

common-mk: default to new FD bindings

This gets us ready to get rid of the old bindings generation so
we can remove references to dbus::FileDescriptor in the libbrillo
bindings.

CQ-DEPEND=CL:996411,CL:996460,CL:996497
CQ-DEPEND=CL:*602092,CL:*602328
BUG= chromium:824839 
TEST=build_packages

Change-Id: I568f46621f7c9ec597e23bb0a11c9b1be2ad9a4f
Reviewed-on: https://chromium-review.googlesource.com/998592
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/da87cd295cf0aa27ae20b8c65e81b94cc6600612/common-mk/generate-dbus-proxies.gypi
[modify] https://crrev.com/da87cd295cf0aa27ae20b8c65e81b94cc6600612/common-mk/generate-dbus-adaptors.gypi

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/29317782e5cb46d1f254aaf46eecf3377ea3abc3

commit 29317782e5cb46d1f254aaf46eecf3377ea3abc3
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Sat Apr 07 05:00:00 2018

chromeos-dbus-bindings: remove old FD bindings

These are unused now.

BUG= chromium:824839 
TEST=unit tests

Change-Id: I9e111aa58a10032cb031fca045472b815287eb1c
Reviewed-on: https://chromium-review.googlesource.com/1000494
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/proxy_generator_unittest.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/dbus_signature.h
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/dbus_signature_unittest.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/dbus_signature.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/generate_chromeos_dbus_bindings.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/proxy_generator.h
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/adaptor_generator_unittest.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/adaptor_generator.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/adaptor_generator.h
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/proxy_generator_mock_unittest.cc
[modify] https://crrev.com/29317782e5cb46d1f254aaf46eecf3377ea3abc3/chromeos-dbus-bindings/proxy_generator.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/840609930a67b99c21abe8cc549cb8a4f8a1e8af

commit 840609930a67b99c21abe8cc549cb8a4f8a1e8af
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Thu Apr 12 01:08:45 2018

chromeos-dbus-bindings: fix README and remove dead code

dbus::FileDescriptor is gone, and we will never emit it. Change
the README to show the new types and remove the dead bits of
DBusSignature that were still indirectly referencing it.

BUG= chromium:824839 
TEST=unit tests

Change-Id: Icce9b1d5b4000f3721b3e13bdd3d356bef213291
Reviewed-on: https://chromium-review.googlesource.com/1007964
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/840609930a67b99c21abe8cc549cb8a4f8a1e8af/chromeos-dbus-bindings/README.md
[modify] https://crrev.com/840609930a67b99c21abe8cc549cb8a4f8a1e8af/chromeos-dbus-bindings/dbus_signature.cc

Sign in to add a comment