New issue
Advanced search Search tips

Issue 824830 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

fast/peerconnection/RTCPeerConnection-many.html is flaky

Project Member Reported by wolenetz@chromium.org, Mar 22 2018

Issue description

The following layout test is flaky timeout/crash on:
Win7 tests (dbg)(1)
win_chromium_dbg_ng

fast/peerconnection/RTCPeerConnection-many.html

results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=rtcpeerconnection-many

Example failure:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win_chromium_dbg_ng/4597

 
I am marking it as flaky.

Comment 3 by hta@chromium.org, Mar 22 2018

Cc: tommi@chromium.org
Interesting. This test is designed to create many peerconnections, which has been limited in the past by # of threads we can create, and Tommi recently landed a change that should have made this better, not worse.

Both examples are on Win7, and I think the test is timing out - is that right?
(I can't see the crash log we usually get when the thread count is exceeded)

Adding Tommi to CC.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f0394f5d1861679d6a15fe7e1c7166ce74a12c5

commit 1f0394f5d1861679d6a15fe7e1c7166ce74a12c5
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Thu Mar 22 17:24:31 2018

fast/peerconnection/RTCPeerConnection-many.html is flaky

Mark as flaky in Win

TBR=hbos@chromium.org,hta@chromium.org

BUG=824830, 823003 
NO-TRY=True

Change-Id: Iabd4ddc714220082b332754c093652178ce91c27
Reviewed-on: https://chromium-review.googlesource.com/976048
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545125}
[modify] https://crrev.com/1f0394f5d1861679d6a15fe7e1c7166ce74a12c5/third_party/WebKit/LayoutTests/TestExpectations

See #1: it's timing out, crashing and passing all in one flaky bot run.
The flakiness dashboard link in OP shows it's green on many bots, excepting some of the win bots where it's very flaky.

Comment 6 by guidou@chromium.org, Mar 23 2018

Owner: hbos@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by tapted@chromium.org, May 25 2018

 Issue 846496  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f527cbed7dfd9f3a8feffd81776112ee4d0771

commit f4f527cbed7dfd9f3a8feffd81776112ee4d0771
Author: Trent Apted <tapted@chromium.org>
Date: Fri May 25 06:30:02 2018

Widen flaky marker for fast/peerconnection/RTCPeerConnection-many.html

It's marked flaky on Win but flakes on Mac also.

TBR=hbos@chromium.org

Bug: 824830,  846496 
Change-Id: I829bd7345a5c78d5e2b0e459a731d902ffabe1ac
Reviewed-on: https://chromium-review.googlesource.com/1073043
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561788}
[modify] https://crrev.com/f4f527cbed7dfd9f3a8feffd81776112ee4d0771/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by hta@chromium.org, May 25 2018

Owner: hta@chromium.org
I'll pick this up. I merged a bug fix yesterday that might have fixed the problem.

Comment 10 by hta@chromium.org, May 25 2018

Teh CL that might have made a difference is https://chromium-review.googlesource.com/c/chromium/src/+/1061176 (would prevent a certain crash).

There are timeouts after this one, so no fix.

New dashboard link (result is on bottom of page):

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fpeerconnection%2FRTCPeerConnection-many.html

Sign in to add a comment