Reposition/Resize - 2D UI Keyboard does not closes on Down Click event |
|||
Issue descriptionChrome Version: 67.0.3376.0 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? 1) Launch www.google.com 2) Enter VR Browsing 3) Click in the Google search box, this should launch the 2D UI Keyboard. 4) Click-Hold on the menu bar 5) Reposition and resize the content window while keeping the click held. What is the expected result? The keyboard should be closed on the Click-Down event. OR Click-Hold for Reposition/Resize should not be allowed. What happens instead? The keyboard stays open while Reposition/Resize activie, until the Click is release. On the Click-Up (release) the keyboard is hidden.
,
Mar 22 2018
,
Mar 22 2018
,
Mar 23 2018
Reposition/resize should now be disabled when doing web input. https://chromium-review.googlesource.com/c/chromium/src/+/976522
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73faa97d7e31f1e4fadeb02620aefc55d322bd05 commit 73faa97d7e31f1e4fadeb02620aefc55d322bd05 Author: Ian Vollick <vollick@chromium.org> Date: Fri Mar 23 00:07:06 2018 [vr] Disable repositioning in conflicting modes For example, when editing you may want to click to dismiss the keyboard, so we should disable repositioning in that mode to avoid confusion. Similarly, we shouldn't allow repositioning while a modal dialog or hosted UI is up. Bug: 824818 , 824822 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I405913b0fae4a6b4dd434dc5e033222bf567006b Reviewed-on: https://chromium-review.googlesource.com/976522 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545296} [modify] https://crrev.com/73faa97d7e31f1e4fadeb02620aefc55d322bd05/chrome/browser/vr/elements/invisible_hit_target.cc [modify] https://crrev.com/73faa97d7e31f1e4fadeb02620aefc55d322bd05/chrome/browser/vr/model/model.cc [modify] https://crrev.com/73faa97d7e31f1e4fadeb02620aefc55d322bd05/chrome/browser/vr/model/model.h [modify] https://crrev.com/73faa97d7e31f1e4fadeb02620aefc55d322bd05/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/73faa97d7e31f1e4fadeb02620aefc55d322bd05/chrome/browser/vr/ui_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by dougman@chromium.org
, Mar 22 2018503 KB
503 KB View Download