New issue
Advanced search Search tips

Issue 824812 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Reposition/Resize - Dialog is displayed in original location, not moved.

Project Member Reported by dougman@chromium.org, Mar 22 2018

Issue description

Chrome Version: 67.0.3376.0 Canary
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
1) Set up Chrome to run permission request test cases
2) Launch https://permission.site/ 
3) Enter VR Browsing
4) Resize content window
5) Click on permission button to display dialog.

What is the expected result?
The Permission dialog should appear in the now location, relative to the current content window position.

What happens instead?
The Permission dialog appears in the original location.

 
Screenshot_20180321-101031.png
426 KB View Download

Comment 1 by tiborg@chromium.org, Mar 22 2018

Owner: tiborg@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-3 Pri-1

Comment 3 by tiborg@chromium.org, Mar 22 2018

Labels: M-67
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aa296ca1b6da58978c461331de754dd454a9a68

commit 0aa296ca1b6da58978c461331de754dd454a9a68
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Mar 23 15:49:14 2018

[vr] Fix visiblity and repositioning of hosted native UI

Currently, the native UI does not align with the repositioned content
quad and is visible when the exit prompt shows. This CL fixes that.

Bug:  824812 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I12f546cb7c5fd4aba2d501443cd0205f59d714cd
Reviewed-on: https://chromium-review.googlesource.com/976182
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545464}
[modify] https://crrev.com/0aa296ca1b6da58978c461331de754dd454a9a68/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/0aa296ca1b6da58978c461331de754dd454a9a68/chrome/browser/vr/ui_unittest.cc

Comment 5 by tiborg@chromium.org, Mar 23 2018

Status: Fixed (was: Started)

Sign in to add a comment