New issue
Advanced search Search tips

Issue 824793 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Password Manager] Create a command-line parameter to expose whether password generation works for a form

Project Member Reported by kolos@chromium.org, Mar 22 2018

Issue description

This is a tracking but for a simple feature: Expose via an HTML attribute of <input> elements whether Chrome would offer password generation for the element.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e66f8cbeb38323a5b0b258ab9b6fc2edf4a115a6

commit e66f8cbeb38323a5b0b258ab9b6fc2edf4a115a6
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Mar 23 10:25:38 2018

[Password Manager] Let the "show-autofill-signatures" flag mark the fields for
password generation

An HTML tag "password_creation_field" will be added to a password field suitable for generation.
The fields that are not suitable for generation will be unchanged.

The flag is used mostly for debugging, testing, collecting train data.

Bug:  824793 

Change-Id: I3c38843eb92617f0060ead0fa0dd6047c2d1d889
Reviewed-on: https://chromium-review.googlesource.com/975161
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545399}
[modify] https://crrev.com/e66f8cbeb38323a5b0b258ab9b6fc2edf4a115a6/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e66f8cbeb38323a5b0b258ab9b6fc2edf4a115a6/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/e66f8cbeb38323a5b0b258ab9b6fc2edf4a115a6/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/e66f8cbeb38323a5b0b258ab9b6fc2edf4a115a6/components/autofill/content/renderer/password_generation_agent.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7bc00ba782c41bdd6455de632ca9d686db2836a

commit b7bc00ba782c41bdd6455de632ca9d686db2836a
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Thu Apr 12 13:00:22 2018

[Password Manager] Show autofill signatures flag should also annotate unowned
 fields.

Bug:  824793 
Change-Id: I44b8fa3da4409c692eec54ecd25f2b306f27d8ba
Reviewed-on: https://chromium-review.googlesource.com/1009903
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550164}
[modify] https://crrev.com/b7bc00ba782c41bdd6455de632ca9d686db2836a/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/b7bc00ba782c41bdd6455de632ca9d686db2836a/components/autofill/content/renderer/password_autofill_agent.cc

Comment 3 by kolos@chromium.org, Apr 12 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bee88272003eab2144751d390a4a331dc23eea47

commit bee88272003eab2144751d390a4a331dc23eea47
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jul 13 10:13:14 2018

[Password Manager] Annotates unowned <input>s with form signature

If chrome://flags/#enable-show-autofill-signatures is enabled, Chrome
annotate forms and fields with its signatures. Before this CL, Chrome didn't
show form signature for formless (i.e. <form> tag) forms.

From this CL, Chrome annotates every field with its field signature and (!)
form signature.

Examples:
<form form_signature="12345">
  <input field_signature="7" form_signature="12345" >
  <input field_signature="8" form_signature="12345" >
</form>

<div>
  <input field_signature="1" form_signature="54321" >
  <input field_signature="2" form_signature="54321" >
</div>

Bug:  824793 
Change-Id: Id5084e616689a9ddae0cccfa345a47f13cc2ab32
Reviewed-on: https://chromium-review.googlesource.com/1134787
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574873}
[modify] https://crrev.com/bee88272003eab2144751d390a4a331dc23eea47/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/bee88272003eab2144751d390a4a331dc23eea47/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/bee88272003eab2144751d390a4a331dc23eea47/chrome/renderer/autofill/password_generation_test_utils.cc
[modify] https://crrev.com/bee88272003eab2144751d390a4a331dc23eea47/chrome/renderer/autofill/password_generation_test_utils.h
[modify] https://crrev.com/bee88272003eab2144751d390a4a331dc23eea47/components/autofill/content/renderer/password_autofill_agent.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e64db336cf6395cc03c9b42ecbba5d46980ef2cc

commit e64db336cf6395cc03c9b42ecbba5d46980ef2cc
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Jul 31 07:42:12 2018

[Password Manager] Add parser annotations to HTML <form> if
#enable-show-autofill-signatures flag is enabled.

<form name="change_password_form" >
  <input type="text" name="username" pm_parser_annotation="username_element" >
  <input type="password" name="current-password" pm_parser_annotation="password_element" >
  <input type="password" name="new-password" pm_parser_annotation="new_password_element" >
  <input type="password" name="password-again" pm_parser_annotation="confirmation_password_element" >
</form>

Bug:  824793 
Change-Id: Ie02de13798abfc0aca0dfe9c47667ff4c52b4163
Reviewed-on: https://chromium-review.googlesource.com/1151315
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579335}
[modify] https://crrev.com/e64db336cf6395cc03c9b42ecbba5d46980ef2cc/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/e64db336cf6395cc03c9b42ecbba5d46980ef2cc/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/e64db336cf6395cc03c9b42ecbba5d46980ef2cc/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/e64db336cf6395cc03c9b42ecbba5d46980ef2cc/components/autofill/content/renderer/password_autofill_agent.h

Sign in to add a comment