New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824779 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 822258



Sign in to add a comment

Catapult AutoRoll bot blocked

Project Member Reported by simonhatch@chromium.org, Mar 22 2018

Issue description

https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/127541

Seems to be largely stuck on some windows tests



pixel_test on NVIDIA GPU on Windows (with patch) on Windows-10 pixel_test on NVIDIA GPU on Windows (with patch) on Windows-10
Run on OS: 'Windows-10'
Shard duration: 0:07:10.931990
Total tests: 46
* Passed: 8 (8 expected, 0 unexpected)
* Skipped: 0 (0 expected, 0 unexpected)
* Failed: 38 (0 expected, >>>38 unexpected<<<)
* Flaky: 0 (0 expected, 0 unexpected)
 
Unexpected Failures:
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_2DCanvasWebGL
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CSS3DBlueBox_SwiftShader
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Canvas2DRedBox
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Canvas2DRedBox_SwiftShader
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Canvas2DUntagged
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CanvasDisplayLinearRGBAccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CanvasDisplayLinearRGBUnaccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvas2DResizeOnWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasAccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasAccelerated2DWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferAfterStyleResize
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferBeforeStyleResize
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferToImageBitmap
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasTransferToImageBitmapWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasWebGLDefault
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasWebGLDefaultWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasWebGLSoftwareCompositing
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasWebGLSoftwareCompositingWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasWebglResizeOnWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_ScissorTestWithPreserveDrawingBuffer
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGL2_BlitFramebuffer_Result_Displayed
* ... 8 more ...
 


screenshot_sync_tests on NVIDIA GPU on Windows (with patch) on Windows-10 screenshot_sync_tests on NVIDIA GPU on Windows (with patch) on Windows-10
Run on OS: 'Windows-10'
Shard duration: 0:02:39.690780
Total tests: 4
* Passed: 0 (0 expected, 0 unexpected)
* Skipped: 0 (0 expected, 0 unexpected)
* Failed: 4 (0 expected, >>>4 unexpected<<<)
* Flaky: 0 (0 expected, 0 unexpected)
 
Unexpected Failures:
* gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_GPURasterWithCanvas
* gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_GPURasterWithDivs
* gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_SWRasterWithCanvas
* gpu_tests.screenshot_sync_integration_test.ScreenshotSyncIntegrationTest.ScreenshotSync_SWRasterWithDivs
 
Cc: kbr@chromium.org
Labels: -Pri-3 Pri-1
+kbr

Ken, do you know what's wrong?

I see a lot of:

"  Traceback (most recent call last):
    _RunGpuTest at content\test\gpu\gpu_tests\gpu_integration_test.py:132
      self.RunActualGpuTest(url, *args)
    RunActualGpuTest at content\test\gpu\gpu_tests\pixel_integration_test.py:141
      tab, page.name, screenshot, page.expected_colors, dpr)
    _ValidateScreenshotSamples at content\test\gpu\gpu_tests\cloud_storage_integration_test_base.py:367
      self.GetParsedCommandLineOptions().test_machine_name)
    _CompareScreenshotSamples at content\test\gpu\gpu_tests\cloud_storage_integration_test_base.py:172
      str(actual_color.b) + "]")
    fail at .swarming_module\bin\Lib\unittest\case.py:410
      raise self.failureException(msg)
  AssertionError: Expected pixel at [1, 1] (actual pixel (1, 1))  to be [102, 77, 0] but got [94, 71, 0]
  
  Locals:
    msg : 'Expected pixel at [1, 1] (actual pixel (1, 1))  to be [102, 77, 0] but got [94, 71, 0]'
"


In the logs
Cc: wangxianzhu@chromium.org
So there's only 5 commits in the bundle of cl's when the roll started failing: https://catapult-roll.skia.org/

one seems to be related to visuals, +wangxianzhu any idea if your cl is related?
Cc: horo@chromium.org
Hmhh, I bet it's "2018-03-19 horo Add --enable-automation flag in GetFromBrowserOptions()" 

I will revert his CL for now
Blockedon: 825174
Blockedon: -825174
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c4e9b13328182a8f4f4be01089215a89f72f02cd

commit c4e9b13328182a8f4f4be01089215a89f72f02cd
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Mar 23 11:58:42 2018

Revert "Add --enable-automation flag in GetFromBrowserOptions()"

This reverts commit df3154eb043fd83fb956978e7fad7e6cab0047d9.

Reason for revert: suspect this breaks all GPU screenshot comparison tests

BUG:  chromium:824779 

Original change's description:
> Add --enable-automation flag in GetFromBrowserOptions()
>
> crrev.com/c/956654 introduced the bad flags warning of "stability and
> security will suffer" for Android.
> This change caused parformance regressions because a bad flag
> "--ignore-certificate-errors-spki-list" is used for perfomance testing.
> (crbug.com/822258#c13)
> So crrev.com/c/965727 introduces the check of "--enable-automation" flag in ShowBadFlagsPrompt().
> (This check already exists in startup_browser_creator_impl.cc for Desktop not
> to show the infobar during performance tests.)
>
> This CL adds the flag to GetFromBrowserOptions().
>
> Bug: chromium:822258
> Change-Id: I8a07c88960678877ee1add1c0d29ad323611a816
> Reviewed-on: https://chromium-review.googlesource.com/965712
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>

TBR=horo@chromium.org,kouhei@chromium.org,perezju@chromium.org,nednguyen@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:822258
Change-Id: I0820fc96c3a0e4988bca19c8c2d55a634feae7be

NOTRY=true
NOPRESUBMIT=true

Change-Id: I0820fc96c3a0e4988bca19c8c2d55a634feae7be
Reviewed-on: https://chromium-review.googlesource.com/977083
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/c4e9b13328182a8f4f4be01089215a89f72f02cd/telemetry/telemetry/internal/backends/chrome/chrome_startup_args.py

Comment 7 by kbr@chromium.org, Mar 27 2018

Blocking: 822258
Owner: simonhatch@chromium.org
Status: Fixed (was: Untriaged)
Closing as Fixed so this can be properly linked to related bugs.

Comment 8 by kbr@chromium.org, Mar 27 2018

Blocking: 825872
Blocking: -825872

Sign in to add a comment