New issue
Advanced search Search tips

Issue 824764 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

comparison of unsigned expression >= 0 is always true

Reported by melanie....@gmail.com, Mar 22 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

Steps to reproduce the problem:
1. compile chromium from source using clang

What is the expected behavior?
no compiler warning regarding this problem

What went wrong?
chromium 65.0.3325.181

../../third_party/WebKit/Source/core/layout/ng/exclusions/ng_exclusion_space.cc:27:48: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
  for (size_t j = opportunities->size() - 1; j >= 0; --j) {
                                             ~ ^  ~

Note: size_t is unsigned

Used Software

kernel 4.15.11
glibc  2.26
gcc 7.2.1+20180116
clang 5.0.1
llvm 5.0.1

Did this work before? N/A 

Chrome version: 65.0.3325.181  Channel: stable
OS Version: 4.15.11
Flash Version:
 
Components: Blink>Layout
Cc: vamshi.kommuri@chromium.org
Labels: Triaged-ET Needs-Triage-M65 TE-NeedsTriageHelp
The issue seems to be out of scope for triaging from our end as this needs to be triaged by compiling Chromium from source using clang. Hence adding label "TE-NeedsTriageHelp" and requesting someone from "Blink>Layout" team to have a look into it and help in triaging the issue further.

Thanks!

Comment 3 by e...@chromium.org, Mar 23 2018

Owner: atotic@chromium.org
Status: Assigned (was: Unconfirmed)
That loop condition probably needs to be rewritten, would you mind taking a look Aleks?

Comment 4 by atotic@chromium.org, Apr 27 2018

Owner: ikilpatrick@chromium.org
you are in this code right now
Still broken.

Sign in to add a comment