New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 824756 link

Starred by 1 user
Status: Fixed
Owner:
treib@chromium.org
Closed: Apr 2018
Cc:
█ bauerb@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 829304



Sign in to add a comment

Sync: Deprecate SUPERVISED_USERS and SUPERVISED_USER_SHARED_SETTINGS

Project Member Reported by treib@chromium.org, Mar 22 2018 
These two model types exist to support (legacy) supervised users, which were deprecated a while back. It should be safe to remove them now.

Note: While no new SUs can be created, existing ones still work for now. We should not accidentally break that.

Note2: SUPERVISED_USER_SETTINGS and SUPERVISED_USER_WHITELISTS are still used for child accounts, and must NOT be removed.

Comment 1 by treib@chromium.org, Apr 18 2018

Blocking: 829304

Comment 2 by treib@chromium.org, Apr 23 2018

Cc: -treib@chromium.org
Owner: treib@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/706f87251734a44a6a3632d03a9e674b3a0f98b5

commit 706f87251734a44a6a3632d03a9e674b3a0f98b5
Author: Marc Treib <treib@chromium.org>
Date: Tue Apr 24 09:08:06 2018

Delete SupervisedUserSharedSettingsService

and everything that's directly related (factory, update) or depends
on it (pref mapping service, (ChromeOS only) SU password service,
manager password service).

Legacy Supervised Users are deprecated, so this isn't needed anymore.

Bug:  824756 
Change-Id: If8dc0841cdb10add42330e193362c28a02668af8
Reviewed-on: https://chromium-review.googlesource.com/1016914
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553040}
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/BUILD.gn
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/manager_password_service.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/manager_password_service.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/manager_password_service_factory.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/manager_password_service_factory.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/supervised_user_password_service.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/supervised_user_password_service.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/supervised_user_password_service_factory.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/chromeos/supervised_user_password_service_factory.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service_factory.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service_factory.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service_unittest.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_factory.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_factory.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_update.cc
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_update.h
[delete] https://crrev.com/f19d674b969640566e6362a990f1a8b39403dadc/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_update_unittest.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
[modify] https://crrev.com/706f87251734a44a6a3632d03a9e674b3a0f98b5/chrome/test/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b0510c813f0fb156e1033f84ee0d51d7216ad5a

commit 4b0510c813f0fb156e1033f84ee0d51d7216ad5a
Author: Marc Treib <treib@chromium.org>
Date: Tue Apr 24 10:59:36 2018

Delete SupervisedUserSyncService

and some (unused) UI code that still depended on it.

Legacy Supervised Users are deprecated, so this isn't needed anymore.

Bug:  824756 
Change-Id: Ib0434298a547aed61550a828514d0be759324dea
Reviewed-on: https://chromium-review.googlesource.com/1019580
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553048}
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/BUILD.gn
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[delete] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc
[delete] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/supervised_user/legacy/supervised_user_sync_service.h
[delete] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/supervised_user/legacy/supervised_user_sync_service_factory.cc
[delete] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/supervised_user/legacy/supervised_user_sync_service_factory.h
[delete] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/supervised_user/legacy/supervised_user_sync_service_observer.h
[delete] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.h
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc
[modify] https://crrev.com/4b0510c813f0fb156e1033f84ee0d51d7216ad5a/chrome/test/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b1bfc1f89241411f625cbd6e5c2cc09adffc272

commit 6b1bfc1f89241411f625cbd6e5c2cc09adffc272
Author: Marc Treib <treib@chromium.org>
Date: Tue Apr 24 14:25:49 2018

Sync: Deprecate SUPERVISED_USERS and SUPERVISED_USER_SHARED_SETTINGS model types

Supervised users are deprecated, and the corresponding SyncableService
implementations are already gone.
This CL adds a DEPRECATED_ prefix to the enum entries, and removes some usages
that aren't needed anymore. However, some uses are still required, e.g. the
pref mappings. I hope to fully remove the enum entries in a followup.

Skipping presubmit because of pre-existing failure (SU model type enum
entries not matching the model type name strings).
NOPRESUBMIT=true

Bug:  824756 
Change-Id: Ic6ffd500e656719424f74fb92889270d1385301e
Reviewed-on: https://chromium-review.googlesource.com/1019404
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553094}
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/components/sync/base/data_type_histogram.h
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/components/sync/base/model_type.h
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/components/sync/base/sync_prefs.cc
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/components/sync/driver/model_association_manager.cc
[modify] https://crrev.com/6b1bfc1f89241411f625cbd6e5c2cc09adffc272/components/sync/syncable/model_type.cc

Comment 6 by treib@chromium.org, Apr 25 2018

Status: Fixed (was: Started)
Let's call this done - the model types are deprecated. It'd be much nicer to actually remove them, but that'd be a lot of work, e.g. making sure that no UMA histograms break. No histograms should use int-ified model types directly, but a bunch of them do use MODEL_TYPE_COUNT as their upper bound. It's also not immediately clear if model types are persisted in int form anywhere etc.
►

Sign in to add a comment