New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824753 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

UnboundLocalError in ChromedriverTestUserLevel test

Project Member Reported by grt@chromium.org, Mar 22 2018

Issue description

In this run, it seems that the test failed for some reason, and then the test harness itself raised an exception:

https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin10_chromium_x64_rel_ng%2F106246%2F%2B%2Frecipes%2Fsteps%2Ftest_installer__with_patch_%2F0%2Fstdout

it's not clear to me what went wrong with the bring-up of a browser process, but here's the python exception details:

Traceback (most recent call last):
  File "test_chrome_with_chromedriver.py", line 117, in <module>
    sys.exit(main())
  File "test_chrome_with_chromedriver.py", line 106, in main
    with CreateChromedriver(args) as driver:
  File "C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "test_chrome_with_chromedriver.py", line 65, in CreateChromedriver
    driver.quit()
UnboundLocalError: local variable 'driver' referenced before assignment
ERROR
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c06c69209455388633bc64273f2eff2152660865

commit c06c69209455388633bc64273f2eff2152660865
Author: Mike Meade <mmeade@google.com>
Date: Fri Mar 23 04:16:48 2018

Fixing a problem when chromedriver fails to start.

If chromedriver fails to start driver never gets assigned,
so calling driver.quit() in finally fails.

This also addresses a possible race condition between Chrome closing and Crashpad releasing some report files.

BUG= 824753 

Change-Id: I11381b49401c1f661d5b5cfc5cae97a9746bfe04
Reviewed-on: https://chromium-review.googlesource.com/975983
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Meade <mmeade@google.com>
Cr-Commit-Position: refs/heads/master@{#545364}
[modify] https://crrev.com/c06c69209455388633bc64273f2eff2152660865/chrome/test/mini_installer/test_chrome_with_chromedriver.py

Comment 2 by mmeade@chromium.org, Mar 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment