New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824748 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !FlowThreadOffset() in ColumnBalancer.cpp

Project Member Reported by ClusterFuzz, Mar 22 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6696585149546496

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !FlowThreadOffset() in ColumnBalancer.cpp
  blink::ColumnBalancer::Traverse
  blink::InitialColumnHeightFinder::InitialColumnHeightFinder
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=529050:529051

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6696585149546496

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 22 2018

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 22 2018

Labels: Test-Predator-Auto-Owner
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ffb5de3934abd4e16399b2f79e7100823c6076fd (Don't propagate cmdline flags that are not read by renderer processes.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: jchaffraix@chromium.org
Owner: mstensho@chromium.org
shend@, could you PTAL?  I think the failing DCHECK was introduced in r353463 (at least I wasn't able to trace the origin of the assert beyond this CL).

jchaffraix@, adding you since you reviewed r353463 and so might also have some background context here.

I am adding Test-Predator-Wrong-CLs label and removing myself as an owner, because I think the explanation from  https://crbug.com/823148#c3  applies here as well.
Labels: Test-Predator-Wrong-CLs
This is a DCHECK failure, not a CHECK failure.
tc.html
184 bytes View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b53b29c27fe6d4b22015471b614a669b35b654f3

commit b53b29c27fe6d4b22015471b614a669b35b654f3
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Sat Mar 24 13:39:49 2018

x+y-y may not be the same as x in saturated arithmetic situations.

The column balancer expects the flow thread offset to be 0 when it's
done, but the DCHECK for that could fail in saturated arithmetic
situations.

Bug:  824748 
Change-Id: I5de094e18b1ba691c1f165cd15ffe16b10cf0a50
Reviewed-on: https://chromium-review.googlesource.com/978141
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545690}
[add] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-insane-offset-crash.html
[modify] https://crrev.com/b53b29c27fe6d4b22015471b614a669b35b654f3/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Mar 25 2018

ClusterFuzz has detected this issue as fixed in range 545687:545690.

Detailed report: https://clusterfuzz.com/testcase?key=6696585149546496

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !FlowThreadOffset() in ColumnBalancer.cpp
  blink::ColumnBalancer::Traverse
  blink::InitialColumnHeightFinder::InitialColumnHeightFinder
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=529050:529051
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=545687:545690

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6696585149546496

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Mar 25 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6696585149546496 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment