New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 824739 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

texImage2d uploads past state of canvas

Reported by ivan.pop...@gmail.com, Mar 22 2018

Issue description

Steps to reproduce the problem:
1. Refresh the page several times until the bug appears. Sometimes it appears at first time
2. Try decelerate the temporary canvas (256x256 instead of 512x512) and see that bug disappears

What is the expected behavior?
Toilets at the bottom, baths at the top.

What went wrong?
Bathroom war. texImage2D uploads wrong canvas state. 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 65.0.3325.109  Channel: n/a
OS Version: 10.0
Flash Version: 

Device: Huawei Nova
Android 7.0
Chrome 65.0.3325.109

Second Device: Meizu M2 Note
Android 5.1.1
Chrome 65.0.3325.109

The bug affects ThreeJS: https://github.com/mrdoob/three.js/issues/13659 , there's 3d version of bathroom war at https://exponenta.github.io/ThreeJsBug/

See https://github.com/eXponenta/ThreeJsBug for screenshots.

This is collaboration between https://github.com/eXponenta/ and https://twitter.com/ivanpopelyshev
 
chrome-canvas-bug-2018-03-22.js
4.4 KB View Download
Sorry, your 400 http error at chromium bugtracker ate my original fiddle link: https://jsfiddle.net/6nLucq2y/15/
Components: Blink>Canvas
Labels: Needs-triage-Mobile
Cc: nyerramilli@chromium.org pnangunoori@chromium.org sandeepkumars@chromium.org
Labels: -Type-Bug -Pri-2 hasbisect-per-revision FoundIn-66 M-67 Target-67 Target-66 RegressedIn-65 Triaged-Mobile FoundIn-65 FoundIn-67 Pri-1 Type-Bug-Regression
Owner: xlai@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue in Android and able to reproduce the issue. 

Steps Followed:
1. Refresh the page several times until the bug appears. Sometimes it appears at first time
2. Try decelerate the temporary canvas (256x256 instead of 512x512) and see that bug disappears
3. texImage2D uploads wrong canvas state

Chrome versions tested:
65.0.3325.109 (Stable), 67.0.3377.0(Canary)

OS:
Android 8.1.0, 7.0.0

Android Devices:
Pixel XL, Samsung J7

Using the per-revision bisect providing the bisect results,
Good Build - 65.0.3312.0 
Bad Build - 65.0.3313.0  

You are looking for a change made after 527295(GOOD), but before 527296(BAD).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+/8d804a372fd8adc4e6114e8762274558d3ac4d00

From the CL above, assigning the issue to the owner concerned.

@xlai: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned.

Please navigate to below link for log's and video--
go/chrome-androidlogs/824739

Note: 
1. This issue is not observed in Desktop.

Thanks!!
Labels: ReleaseBlock-Stable
This seems to a recent regression, please have a fix before M67 hits stable.

Comment 6 by xlai@chromium.org, Mar 28 2018

Cc: junov@chromium.org
Labels: -ReleaseBlock-Stable -M-67 -FoundIn-66 -FoundIn-67 -Target-66 -Target-67
Status: Fixed (was: Assigned)
I tested this test page on Google Nexus 6 and Google Pixel XL.

While the bug is reproducible on stable Chrome (65.0.3325.109), it is no longer seen on latest Canary (67.0.3382.0). In addition, the bug is not observed in Chrome Dev (67.0.3381.2) and Chrome Beta (66.0.3359.46).

I did a commit-by-commit bisecting and then found out that junov@ has fixed this in the following CL

https://chromium-review.googlesource.com/c/chromium/src/+/960423

which fixed the sync issue in AcceleratedStaticBitmapImage::CopyToTexture, the function that my CL tried to merge with the original CopyImageToTexture.

So yah, mark it fixed. Thanks, Justin.



Sign in to add a comment